Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip LatexToUnicodeProcessorTest if pandoc is not found #72

Closed

Conversation

arandilopez
Copy link
Contributor

Hi. This PR resolves #68 by marking the test as incomplete is pandoc command is not found on the system. Other tests pass but this 3 tests get marked as skiped and php prints a warning about it with the text: 'Pandoc is not found, skiping this test'

@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

Merging #72 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #72   +/-   ##
=========================================
  Coverage     90.38%   90.38%           
  Complexity      175      175           
=========================================
  Files             9        9           
  Lines           468      468           
=========================================
  Hits            423      423           
  Misses           45       45

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1922ca...8d51925. Read the comment docs.

@renanbr
Copy link
Owner

renanbr commented Oct 18, 2019

Nice, I'll check this soon

@renanbr
Copy link
Owner

renanbr commented Oct 19, 2019

Thank you,

I would prefer to mimic the Pandoc class check, run exec('which pandoc', $output, $returnVar);, then check $returnVar like in Pandoc class

Could you make this change before I merge it?

@arandilopez
Copy link
Contributor Author

@renanbr

Sure, I'll make the change

@renanbr
Copy link
Owner

renanbr commented Oct 20, 2019

thank you @arandilopez
merged as 1edf152 (i just squashed before merge 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip LatexToUnicodeProcessor tests when pandoc isn't available
2 participants