Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Make PhotoViewController.scale should not be null #523

Open
alestiago opened this issue Aug 26, 2022 · 1 comment
Open

[BUG] Make PhotoViewController.scale should not be null #523

alestiago opened this issue Aug 26, 2022 · 1 comment
Labels
bug Something isn't working P3

Comments

@alestiago
Copy link

Describe the bug
Currently, PhotoViewController.scale is nullable. However, this value should not be null according to @renancaraujo.

Although, I do not envision how this value can be nullable. If so, docs should be added to document under what scenarios this values is nullable.

To Reproduce
(

)

What is the current behavior?
PhotoViewController.scale is double? == true
PhotoViewController.scale is double == false

Expected behavior
PhotoViewController.scale is double == true

Screenshots
N/a

Which versions of Flutter/Photo View, and which browser / OS are affected by this issue? Did this work in previous versions of Photo View?

Photo View ^0.14.0

Flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.0.5, on macOS 12.2.1 21D62 darwin-arm, locale
    en-GB)
[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2021.2)
[✓] VS Code (version 1.70.2)
[✓] Connected device (3 available)
[✓] HTTP Host Availability

• No issues found!

@alestiago alestiago added the bug Something isn't working label Aug 26, 2022
@alestiago
Copy link
Author

(cc: @renancaraujo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
None yet
Development

No branches or pull requests

2 participants