Change class methods to static where possible

renatahodovan · Feb 24, 2020 · da24ffe · da24ffe
1 parent 06ab3c0
commit da24ffe
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/grammarinator/model/default_model.py b/grammarinator/model/default_model.py
@@ -10,7 +10,8 @@
 
 class DefaultModel(object):
 
-    def random_decision(self):
+    @staticmethod
+    def random_decision():
         return bool(random.getrandbits(1))
 
     def choice(self, name, choices):

diff --git a/grammarinator/runtime/generator.py b/grammarinator/runtime/generator.py
@@ -80,14 +80,18 @@ def create_node(self, node):
         self.root = self.root or node
         return node
 
-    def char_from_list(self, options):
+    @staticmethod
+    def char_from_list(options):
         return chr(random.choice(options))
 
-    def any_ascii_char(self):
+    @staticmethod
+    def any_ascii_char():
         return random.choice(string.printable)
 
-    def any_unicode_char(self):
-        return self.char_from_list(printable_unicode_chars)
+    @staticmethod
+    def any_unicode_char():
+        return Generator.char_from_list(printable_unicode_chars)
 
-    def any_ascii_letter(self):
+    @staticmethod
+    def any_ascii_letter():
         return random.choice(string.ascii_letters)