Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selecting an entire value and hitting delete should delete the selected value #43

Closed
2 of 6 tasks
scottmcpherson opened this issue Jun 21, 2018 · 6 comments · Fixed by #44
Closed
2 of 6 tasks

Selecting an entire value and hitting delete should delete the selected value #43

scottmcpherson opened this issue Jun 21, 2018 · 6 comments · Fixed by #44
Labels
enhancement New feature or request number mask Refers to the `createNumberMask`

Comments

@scottmcpherson
Copy link
Contributor

scottmcpherson commented Jun 21, 2018 •
edited
Loading

What are you reporting?

Currently, the only way to delete the entire value is by hitting delete once for each digit. It would be a better UX to be able to select the entire value and delete it by hitting delete once.

  • Bug
  • Feature request
  • Code refactor
  • Continuous Integration (CI) improvement
  • Changes in documentation (docs)
  • Other (describe)

raisal - broker 2018-06-21 14-51-51
@renato-bohler renato-bohler added enhancement New feature or request number mask Refers to the `createNumberMask` labels Jun 21, 2018
@renato-bohler
Copy link
Owner

I totally agree. I'll give it a try in the next few weeks.

@scottmcpherson
Copy link
Contributor Author

Let me know if I can help! Happy to submit a PR

@renato-bohler
Copy link
Owner

Sure! It shouldn't be too hard to solve. If you want to submit a PR I'll be happy to review it.

@scottmcpherson
Copy link
Contributor Author

scottmcpherson commented Jun 23, 2018 •
edited
Loading

@renato-bohler I was able to resolve this but wanted to check with you before modifying the test to get them to pass.

To get this to work, part of what I did was removed this block:
https://github.com/renato-bohler/redux-form-input-masks/blob/master/src/createNumberMask.js#L60-L66

What is the purpose of this block? With it removed, it still prevents the modification of suffixes and prefixes.

@renato-bohler
Copy link
Owner

Yes, tests will have to be updated.

I would have to check, but I suspect that without this block, messing only with the prefix and suffix would clear the input, and in this case the input field should just not be updated.

scottmcpherson added a commit to scottmcpherson/redux-form-input-masks that referenced this issue Jun 26, 2018
@scottmcpherson
fix(CreateNumberMask.js): allow full select delete
8aa92c9 
fix renato-bohler#43
@scottmcpherson scottmcpherson mentioned this issue Jun 26, 2018
Merged
renato-bohler added a commit that referenced this issue Jun 26, 2018
@renato-bohler
chore(release): 1.1.5 [skip ci]
0cfe7a9 
<a name="1.1.5"></a>
## [1.1.5](v1.1.4...v1.1.5) (2018-06-26)

### Bug Fixes

* **CreateNumberMask.js:** allow full select delete ([8aa92c9](8aa92c9)), closes [#43](#43)
@renato-bohler
Copy link
Owner

🎉 This issue has been resolved in version 1.1.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request number mask Refers to the `createNumberMask`
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(CreateNumberMask.js): allow full select delete scottmcpherson/redux-form-input-masks
2 participants
@scottmcpherson @renato-bohler