Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test other distros than alpine #2

Closed
renatomefi opened this issue Sep 11, 2018 · 0 comments
Closed

Test other distros than alpine #2

renatomefi opened this issue Sep 11, 2018 · 0 comments
Labels
enhancement New feature or request
Milestone
Tests improvement

Comments

@renatomefi
Copy link
Owner

Context

Currently the test matrix only tests alpine images, would be good to be able to test strecht for instance.

Impact

  • tests might differ, I recommend using pytest mark feature to separate those distro specific
  • docker.sh has to adhere to the marks, build and run this matrix, maybe the make file could inform which Dockerfile to look at
@renatomefi renatomefi added the enhancement New feature or request label Sep 11, 2018
@renatomefi renatomefi added this to the Tests improvement milestone Sep 11, 2018
renatomefi added a commit that referenced this issue Sep 18, 2018
@renatomefi
Test against Debian Stretch and Dash
1476651 
Fixes #2
By testing Debian Stretch we validate also how it's working on dash,
since busybox tends to implement bash features.
The solution was to split Dockerfiles and mark the tests which can't be
run in both distros.
fernandesGabriel pushed a commit to fernandesGabriel/php-fpm-healthcheck that referenced this issue Nov 28, 2020
@renatomefi
Test against Debian Stretch and Dash
b4b92dc 
Fixes renatomefi#2
By testing Debian Stretch we validate also how it's working on dash,
since busybox tends to implement bash features.
The solution was to split Dockerfiles and mark the tests which can't be
run in both distros.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Tests improvement
Development

No branches or pull requests
1 participant
@renatomefi