Skip to content

Commit

Permalink
Merge pull request #448 from render-engine/🐛---Archive-isnt-getting-c…
Browse files Browse the repository at this point in the history
…lass-page-name
  • Loading branch information
kjaymiller committed Dec 7, 2023
2 parents cd7a007 + 168cadd commit aefe457
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 10 deletions.
3 changes: 2 additions & 1 deletion src/render_engine/archive.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ def __init__(
plugin_manager: PluginManager | None = None,
) -> None:
super().__init__()
self.slug = title
self.title = title
self.archive_index = archive_index

if archive_index:
Expand All @@ -46,5 +48,4 @@ def __init__(
self.plugin_manager = plugin_manager
self.routes = routes
self.template = template
self.title = title
self.template_vars = template_vars
26 changes: 17 additions & 9 deletions tests/test_archive.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,26 @@
import pytest

from render_engine.archive import Archive
from render_engine.page import Page


def test_archive_slug_name_with_pages():
def test_archive_slug_named_after_title():
"""Archives usually get their name from their collection. This tests that the slug is named after the title"""

archive = Archive(title="test archive", pages=[Page()], template="", routes=["./"], template_vars={})

assert archive._slug == "test-archive"


@pytest.mark.parametrize(
"title, expected_slug",
[("archive", "archive1"), ("collection", "collection1"), ("Test Collection", "test-collection1")],
)
def test_archive_slug_name_with_pages(title, expected_slug):
"""tests that if num_archive_pages is greater than 1, the slug is appended with the archive_index"""

archive = Archive(
title="archive",
pages=[Page()],
template="",
routes=["./"],
archive_index=1,
num_archive_pages=2,
template_vars={}
title=title, pages=[Page()], template="", routes=["./"], archive_index=1, num_archive_pages=2, template_vars={}
)

assert archive.slug == "archive1"
assert archive._slug == expected_slug

0 comments on commit aefe457

Please sign in to comment.