Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links #314

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix broken links #314

merged 1 commit into from
Oct 30, 2023

Conversation

LauraLangdon
Copy link
Contributor

Just fixes for some broken links.

@LauraLangdon LauraLangdon mentioned this pull request Oct 27, 2023
Closed
kjaymiller
kjaymiller reviewed Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@kjaymiller kjaymiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern with these is that the links are pointing directly to the markdown files and may not resolve correctly with readthedocs.

I'm not sure how we can test this without taking down the docs page temporarily.

@kjaymiller
Copy link
Collaborator

@LauraLangdon if you're ready I can approve and merge these changes in

@LauraLangdon LauraLangdon marked this pull request as ready for review October 30, 2023 17:45
@LauraLangdon
Copy link
Contributor Author

Sounds good!

@kjaymiller kjaymiller merged commit 9165151 into render-engine:main Oct 30, 2023
1 check passed
@LauraLangdon LauraLangdon deleted the fix-links branch October 30, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjaymiller kjaymiller kjaymiller left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LauraLangdon @kjaymiller