Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render-engine serve build is now an Argument #412

Merged
merged 4 commits into from
Nov 22, 2023
Merged

render-engine serve build is now an Argument #412

merged 4 commits into from
Nov 22, 2023

Conversation

kjaymiller
Copy link
Collaborator

@kjaymiller kjaymiller commented Nov 22, 2023 •
edited
Loading

Summary

  • Makes serving the site trigger a build by default.
  • Moves the module_site split to a callback that can raise an error if the
  • renames site_module to module_site with cli.build
  • adds tests
  • updates docs

Type of Issue

  • 🐛 (bug)
  • 📖 (Documentation)
  • 💫 (New Feature)
  • ☢️ (Deprecation)
  • 🚫 (Removal)

Issues Referenced

resolves #328, #411

@kjaymiller kjaymiller merged commit 40ec06e into main Nov 22, 2023
4 checks passed
@kjaymiller kjaymiller deleted the kjaymiller/issue328 branch November 22, 2023 13:33
@kjaymiller kjaymiller linked an issue Nov 22, 2023 that may be closed by this pull request
Use typer callback to check for the correct format (raising an error if incorrect) #411
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Render Engine
Status: Done
Milestone
No milestone
1 participant
@kjaymiller