New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This fix the issue #2 #3
base: master
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,7 @@ | |||
Given (/^I run the application with options "(.*?)"$/) do |options| | |||
run "tli #{options}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 (not 1) spaces for indentation.
Tab detected.
end | ||
|
||
context 'with invalid languages' do | ||
it 'should raise error' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Thanks for your effort, just one thing, add more tests to keep test coverage high (green). Go to coveralls and check what code paths are lacking tests. Or use simplecov locally, in
Don't forget to revert this change before sending the pull request. |
I've created the respective tests, and make them pass, for fix the issue #2.