Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This fix the issue #2 #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

This fix the issue #2 #3

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2015

I've created the respective tests, and make them pass, for fix the issue #2.

@@ -0,0 +1,7 @@
Given (/^I run the application with options "(.*?)"$/) do |options|
run "tli #{options}"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 (not 1) spaces for indentation.
Tab detected.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.92%) to 89.02% when pulling 0690997 on sgmart:master into 97e70fb on rendon:master.

end

context 'with invalid languages' do
it 'should raise error' do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@coveralls
Copy link

Coverage Status

Coverage decreased (-9.92%) to 89.02% when pulling fff8e94 on sgmart:master into 97e70fb on rendon:master.

@rendon
Copy link
Owner

rendon commented Apr 27, 2015

Thanks for your effort, just one thing, add more tests to keep test coverage high (green). Go to coveralls and check what code paths are lacking tests. Or use simplecov locally, in spec/spec_helper.rb change coveralls by simplecov:

# require 'simplecov'
# SimpleCov.start
require 'coveralls'
Coveralls.wear!
        |
        |
        v
require 'simplecov'
SimpleCov.start
#require 'coveralls'
#Coveralls.wear!

Don't forget to revert this change before sending the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants