Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls #332

Merged
merged 4 commits into from
Feb 27, 2014
Merged

Coveralls #332

merged 4 commits into from
Feb 27, 2014

Conversation

c089
Copy link
Member

@c089 c089 commented Feb 26, 2014

No description provided.

@c089
Copy link
Member Author

c089 commented Feb 26, 2014

Let's wait for travis to see if it works. Note for self, should also add the badge to the README.md.

Got bored at the hostel. With 💌 from Krakow

@@ -29,7 +30,8 @@
"istanbul": "~0.1.10",
"jquery": "~1.8.3",
"rendr-handlebars": "0.2.0",
"proxyquire": "0.5.2"
"proxyquire": "0.5.2",
"coveralls": "^2.8.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fails with node 0.8 (which has an older npm version).

But maybe we should drop node 0.8 support anyway, I think its npm version doesn’t support peerDependencies which was a problem in #246 (cc: @spikebrehm).

@lo1tuma
Copy link
Member

lo1tuma commented Feb 26, 2014

👍 for coveralls, a badge would be nice.

@spikebrehm
Copy link
Member

Awesome! Never heard of Coveralls. A little scared to see our initial coverage stats 😮.

You're right, we should explicitly drop support for 0.10 due to peerDependencies.

@c089
Copy link
Member Author

c089 commented Feb 27, 2014

Awesome! Never heard of Coveralls. A little scared to see our initial coverage stats 😮.
Well @lo1tuma already did great work at improving it. Coveralls picked up the PR and reports 77%, but for some reason it shows it as being on the master branch?!

@c089
Copy link
Member Author

c089 commented Feb 27, 2014

Regarding dropping 0.8, ACK but I prefer fixed versions anyway so I went that route and will drop 0.8 in a separate PR.

@c089
Copy link
Member Author

c089 commented Feb 27, 2014

Ah of course the branch only exists on my repo, not rendrjs juts a bit confusing that it shows it as "master" but that's probably because I want to merge to master. I think this one is ready to merge.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5b277b6 on c089:coveralls into * on rendrjs:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ca9dd6e on c089:coveralls into * on rendrjs:master*.

lo1tuma added a commit that referenced this pull request Feb 27, 2014
@lo1tuma lo1tuma merged commit 74e9277 into rendrjs:master Feb 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants