-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify getBootstrappedData to check properties for more models and collections #372
Merged
saponifi3d
merged 3 commits into
rendrjs:master
from
saponifi3d:bootstrapData-recursive
Jun 21, 2014
Merged
Modify getBootstrappedData to check properties for more models and collections #372
saponifi3d
merged 3 commits into
rendrjs:master
from
saponifi3d:bootstrapData-recursive
Jun 21, 2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it out correctly for the bootstrapData
This would be really helpful for our project. |
@@ -107,5 +107,27 @@ describe('ViewEngine', function() { | |||
|
|||
data.should.deep.equal({}); | |||
}); | |||
|
|||
it('should create a flat bootstrap object if a model has a nested model', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing a test.
Does this fix #263? |
saponifi3d
added a commit
that referenced
this pull request
Jun 21, 2014
Modify getBootstrappedData to check properties for more models and collections fixes #263
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into an issue where a model which contains nested models doesn't correctly get passed from the server to the client.
This PR makes it so we can use the
parse
function to build out models and then still havebootstrapData
hydrate the view.usage:
Then this
subModel
will be added to the bootstrapData correctly, putting both the Model and SubModel intomodelStore
in the hydration step... makingview "subModelView" model=subModel
work in the template to correctly get the data for a subview.This is a fix for: #263