Attach views back in series instead of async #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@rendrjs/maintainers Can you take a look please? AMD gods will appreciate it :) |
|
👍 |
|
Seems okay, @jmerrifield might want to try it out with browserify to verify it doesn't break that one too :) yay amd vs commonjs. |
|
@saponifi3d Sorry, I got carried away with work things and lagging behind on testing app. (Looking forward for the holidays). :) |
|
No worries. I haven't had time to get to it yet either. :'( |
|
@jmerrifield Any news on browserify front? :) Thanks. |
|
Haven't had a chance to check this yet, and won't be back at work until Monday to do so. I think this change will be totally fine though, probably no need to wait on me :) |
saponifi3d
added a commit
that referenced
this pull request
Dec 4, 2015
Attach views back in series instead of async
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using rendr with
requirejsin AMD mode the child views are attached withnullas parent on the first render. Because we are waiting for the module to be loaded . This change is to forcefully attach the views in series.