Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client side issue when partial view is nested in another partial view #512

Closed

Conversation

brian-hall
Copy link

A view that is comprised of nested partial views fails when rendered on the client.

example emblem setup would be:

partial_1.emblem:

div
h2 Partial 1
== _block

partial_2.emblem:

div
h2 Partial 2
== _block

sub_view.emblem:

h2 Sub View

main_view.emblem:

= view partial_1
=view partial_2
= sub_view

@saponifi3d
Copy link
Contributor

This is an issue with the view layer and not with rendr itself.

Since I have a little bit of insight on what you're stack is like, 😛, you should make this change in rendr-handlebars. (https://github.com/rendrjs/rendr-handlebars/blob/master/shared/helpers/view.js is where the fix should probably go)

However, I've not seeing issues with doing this in the past.

@saponifi3d saponifi3d closed this Feb 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants