angular module: Move options into single attribute and provide it as json

[mrzmyr]

We should provide the options format for the angular module as JSON format in a separated attribute to be more conventional. That also will solve issues like referencing to variables (#44).

Example for easy-pie-chart:

<div 
    easypiehcart
    ng-options="{ barColor: '#ef1e25', trackColor': '#f2f2f2', 'scaleColor': '#dfe0e0', 'scaleLength': 5 }"
    ng-percent="percent"
></div>

A way better:

<div easypiechart ng-options="options" ng-percent="percent"></div>

var app = angular.module('app', ['easypiechart']);
app.controller('chartCtrl', ['$scope', function ($scope) {
    $scope.percent = 65;
    $scope.options = { 
        barColor: '#ef1e25', 
        trackColor: '#f2f2f2', 
        scaleColor: '#dfe0e0', 
        scaleLength: 5
    };
}]);

What do you think about it ?

[rendro]

I appreciate this approach as we already discussed. Defining the options in a controller seems more convenient to me than the css-style version that has to be parsed when the module is initialized.

[alex6o]

hi! this proposed structure is exactly what iam searching for! +1 options would be more flexible and reusable ...

[thelarz]

I made this change locally, works great for my purposes. But if you release a version with this feature, I'll update to that release.

[rendro]

@thelarz the community and the repository would benefit by you opening a pull request with your changes

[thelarz]

I'd be glad to. Check my work, I'm no JS guru.

[rendro]

Can you please open a pull request or tell me where to find your code. Never mind, no one needs to be a guru to make a meaningful contribution ;)

[mrzmyr]

added to development branch: #51 and will be released in 2.1.0

[thelarz]

Sorry, out of pocket today but I'm anxious to get this going. I had to
clone the repo and copy my changes in, figure out grunt, etc. Was working
on a bug I created that is causing the interior value to not display.

Sent from my iPhone

On Oct 18, 2013, at 8:41 AM, Robert Fleischmann notifications@github.com
wrote:

Can you please open a pull request or tell me where to find your code.
Never mind, no one needs to be a guru to make a meaningful contribution ;)

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/47#issuecomment-26596162
.