Tox and other changes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tox and configure it to test python 2.7 and 3.4 along with both 32 and 64 bit variants. To test using tox these versions of python need to be installed in at the correct location. Also configure tox to run show_hids.py as a test and to run pylint to check for errors.
Fix a typo in core.py, along with suppressing false-positives detected by pylint.
Add the file example-requirements.txt for modules required by examples but not required by the pywinusb library.
Make the following changes to ensure consistent behavior between python 2 and python 3: -Don't allow old importing syntax -Explicitly use the new style print function -Use integer division explicitly -Add python 3 compatibility check to tox using pylint
Trim trailing whitespace from the project. To confirm that nothing important changed in the process astor was used. The only changes that effected the generated code were to docstrings, which will not cause problems. These changes are: -hid\__init__.py line 5: trailing whitespace removed from docstring -core.py line 47: trailing whitespace removed from docstring -hid_pnp_mixin.py line 52: trailing whitespace removed from docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally got around to some of the low priority changes I was planning on doing a while back. The biggest purpose of this is to make testing easier. Tox is able to test several versions of python using virtual environments along with pylint for error and python 3 compatibility checking. Let me know what you think. There is no rush to merge this, I just made a pull request so I wouldn't forget about it. Also if you want to see any more versions of python tested, let me know and I'll add them to tox.