-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/adjustments #20
Refactoring/adjustments #20
Conversation
@reneoelke for the next steps phpcs2 is required and it is currently used by the master branch so I reverted your changes for that. Major benefits are:
Otherwise there is no difference in just running the tests with the default reporting. An other change reverted is the |
@reneoelke experimentally I tested against hhvm which currently fails. If it is trivial to fix I will keep this otherwise it will be dropped for now. The inclusion of hashbanged phpcs from the binary may be an issue. Will test this later on. |
@reneoelke the issue lies with I will temporarily mark hhvm invalid until this is fixed. |
@@ -1,2 +1,3 @@ | |||
/vendor | |||
/phpunit.xml | |||
/composer.lock |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for removing the composer.lock file? It is official recommended to save this in git (see https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file "Commit your application's composer.lock (along with composer.json) into version control.").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no need for it and we opted against. It is recommended only for non-libraries. As we did not discuss this any further I reverted your change.
|
@reneoelke adjusted to use stable phpcs 1.5.3 using composer.lock updating to With this the pull request is completed. Would you like to review it again? |
Various minor fixes/ reversions: