#145: Better error message when calling innerText or innerXml on …

…nodes without children.
renggli · May 25, 2022 · 193576e · 193576e
1 parent b21ca01
commit 193576e
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 3 deletions.
diff --git a/lib/src/xml/mixins/has_text.dart b/lib/src/xml/mixins/has_text.dart
@@ -19,6 +19,10 @@ mixin XmlHasText implements XmlChildrenBase {
 
   /// Replaces the children of this node with text contents.
   set innerText(String value) {
+    if (this is! XmlHasChildren) {
+      throw UnsupportedError(
+          '${(this as XmlNode).nodeType} cannot have child nodes.');
+    }
     children.clear();
     if (value.isNotEmpty) {
       children.add(XmlText(value));

diff --git a/lib/src/xml/mixins/has_xml.dart b/lib/src/xml/mixins/has_xml.dart
@@ -1,4 +1,5 @@
 import '../nodes/document_fragment.dart';
+import '../nodes/node.dart';
 import 'has_children.dart';
 import 'has_parent.dart';
 import 'has_writer.dart';
@@ -15,7 +16,14 @@ mixin XmlHasXml implements XmlChildrenBase, XmlParentBase, XmlHasWriter {
   String get innerXml => children.map((node) => node.toXmlString()).join();
 
   /// Replaces the markup representing the child nodes of this node.
-  set innerXml(String value) => children
-    ..clear()
-    ..add(XmlDocumentFragment.parse(value));
+  set innerXml(String value) {
+    if (this is! XmlHasChildren) {
+      throw UnsupportedError(
+          '${(this as XmlNode).nodeType} cannot have child nodes.');
+    }
+    children.clear();
+    if (value.isNotEmpty) {
+      children.add(XmlDocumentFragment.parse(value));
+    }
+  }
 }
diff --git a/test/mutate_test.dart b/test/mutate_test.dart
@@ -254,6 +254,15 @@ void main() {
       },
       '<element/>',
     );
+    throwingTest(
+      'unsupported text node',
+      '<element>contents</element>',
+      (node) {
+        expect(node.firstChild, isA<XmlText>());
+        node.firstChild!.innerText = 'error';
+      },
+      throwsUnsupportedError,
+    );
   });
   group('innerXml', () {
     mutatingTest(
@@ -277,6 +286,15 @@ void main() {
       },
       '<element/>',
     );
+    throwingTest(
+      'unsupported text node',
+      '<element>contents</element>',
+      (node) {
+        expect(node.firstChild, isA<XmlText>());
+        node.firstChild!.innerXml = 'error';
+      },
+      throwsUnsupportedError,
+    );
   });
   group('outerXml', () {
     mutatingTest(