Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update babylon #54

Closed
wants to merge 2 commits into from
Closed

update babylon #54

wants to merge 2 commits into from

Conversation

jquense
Copy link
Contributor

@jquense jquense commented Jan 25, 2018

Updates babylon for some newer syntax features. The downside here is that its bit stricter about what you can include, so no double decorators and no flow and typescript at the same time. To make up for this i added the ability to pass options parserOptions through to it so a user can configure to their hearts content

@renke
Copy link
Owner

renke commented Jan 28, 2018

Hi @jquense

how likely is it that this causes problems for regular users of import-sort?

@jquense
Copy link
Contributor Author

jquense commented Jan 28, 2018

That's hard to say. I think the most likely place it would affect forks is when they are using decorators in an odd way... Honestly tho I don't know the current existing config is already sort of broken, e.g. Has both typescript and flow enabled, which wouldn't work because their syntax overlaps.

On the flip side as a regular user of import-sort nit having this is not great, we've already forked the parser in order to upgrade to Babel 7 for our app

@renke
Copy link
Owner

renke commented Jun 24, 2018

The new parser from Babel 7 will be used in the next release. I also removed the potentially conflicting plugins. The parserOptions is not included, however, I am not sure we really need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants