Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample modulation set fixes and updates #22

Merged
merged 4 commits into from Feb 29, 2024

Conversation

unlessgames
Copy link
Contributor

Fixed a missing parameter noted on the forum

Added an enum for possible filter types from version 3.

Although I don't quite understand how filter types work. Is the available_types list always the same for current Renoise and only legacy imported songs can have different (or less) types?

If so it might still be better to include each version's types as an enum here and use that instead of a plain string as input.

@emuell
Copy link
Member

emuell commented Feb 29, 2024

Yes, the available filter types change with the 'filter_version'. Old songs may use old filters. They then can be upgraded via upgrade_filter_version function.

Here's the full list:

---Available filter types when filter_version = 1
---@alias FilterTypes1
---"None"
---"LP -12 dB"
---"LP -24 dB"
---"LP -48 dB"
---"Moog LP"
---"Single Pole"
---"HP -12 dB"
---"HP -24 dB"
---"Moog HP"
---"Band Reject"
---"Band Pass"
---"EQ -15 dB"
---"EQ -6 dB"
---"EQ +6 dB"
---"EQ +15 dB"
---"Peaking EQ"
---"Dist. Low"
---"Dist. Mid"
---"Dist. High"
---"Dist."
---"AMod"

---Available filter types when filter_version = 2
---@alias FilterTypes2
---|"None"
---|"LP 2x2 Pole"
---|"LP 2 Pole"
---|"LP Biquad"
---|"LP Moog"
---|"LP Single"
---|"HP 2x2 Pole"
---|"HP 2 Pole"
---|"HP Moog"
---|"Band Reject"
---|"Band Pass"
---|"EQ -15 dB"
---|"EQ -6 dB"
---|"EQ +6 dB"
---|"EQ +15 dB"
---|"EQ Peaking"
---|"Dist. Low"
---|"Dist. Mid"
---|"Dist. High"
---|"Dist."
---|"RingMod"

---Available filter types when filter_version = 3
---@alias FilterTypes3 
---|"None"
---|"LP Clean"
---|"LP K35"
---|"LP Moog"
---|"LP Diode"
---|"HP Clean"
---|"HP K35"
---|"HP Moog"
---|"BP Clean"
---|"BP K35"
---|"BP Moog"
---|"BandPass"
---|"BandStop"
---|"Vowel"
---|"Comb"
---|"Decimator"
---|"Dist Shape"
---|"Dist Fold"
---|"AM Sine"
---|"AM Triangle"
---|"AM Saw"
---|"AM Pulse"

@unlessgames
Copy link
Contributor Author

Thanks! I included those as well.

@emuell emuell merged commit 1d84523 into renoise:main Feb 29, 2024
@unlessgames unlessgames deleted the origin/fix-sample-modulation-set branch March 1, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants