only show the acceptable format one time per format on exception

Signed-off-by: John Nunemaker <nunemaker@gmail.com>
renoke · Mar 30, 2009 · 0b067f7 · 0b067f7
1 parent acd3068
commit 0b067f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/httparty.rb b/lib/httparty.rb
@@ -102,7 +102,7 @@ def cookies(h={})
     #     format :json
     #   end
     def format(f)
-      raise UnsupportedFormat, "Must be one of: #{AllowedFormats.values.join(', ')}" unless AllowedFormats.value?(f)
+      raise UnsupportedFormat, "Must be one of: #{AllowedFormats.values.uniq.join(', ')}" unless AllowedFormats.value?(f)
       default_options[:format] = f
     end
 

diff --git a/spec/httparty_spec.rb b/spec/httparty_spec.rb
@@ -159,6 +159,13 @@ def second_method
         @klass.format :foobar
       end.should raise_error(HTTParty::UnsupportedFormat)
     end
+
+    it 'should only print each format once with an exception' do
+      lambda do
+        @klass.format :foobar
+      end.should raise_error(HTTParty::UnsupportedFormat, "Must be one of: json, xml, html, yaml, plain")
+    end
+
   end
 
   describe "with explicit override of automatic redirect handling" do