Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to directly load a kubeconfig from an array #181

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

stefankonig
Copy link
Contributor

Im working on an application that builds a kubeconfig (array) within PHP. It would be nice to directly use that as config in php-k8s. Currenly i have to convert it to a yaml, only for to be parsed back to an array in fromKubeConfigYaml

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #181 (4f8d429) into master (68180b2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #181   +/-   ##
=========================================
  Coverage     95.17%   95.18%           
- Complexity      690      691    +1     
=========================================
  Files            70       70           
  Lines          1680     1683    +3     
=========================================
+ Hits           1599     1602    +3     
  Misses           81       81           
Impacted Files Coverage Δ
src/Traits/Cluster/LoadsFromKubeConfig.php 93.33% <100.00%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68180b2...4f8d429. Read the comment docs.

@rennokki rennokki merged commit 2949399 into renoki-co:master Dec 30, 2021
@rennokki
Copy link
Member

Great job! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants