Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 188 #189

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Fixes 188 #189

merged 3 commits into from
Feb 3, 2022

Conversation

declum
Copy link
Contributor

@declum declum commented Jan 21, 2022

Fixes #188

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #189 (d9e40c5) into master (4614031) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #189      +/-   ##
============================================
- Coverage     95.22%   95.17%   -0.06%     
- Complexity      694      695       +1     
============================================
  Files            70       70              
  Lines          1696     1698       +2     
============================================
+ Hits           1615     1616       +1     
- Misses           81       82       +1     
Impacted Files Coverage Δ
src/Kinds/K8sResource.php 91.07% <66.66%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4614031...d9e40c5. Read the comment docs.

@rennokki rennokki merged commit e8a36ef into renoki-co:master Feb 3, 2022
@rennokki
Copy link
Member

rennokki commented Feb 3, 2022

Sorry for the delay. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8sResource.php#L100 return false only on $e->getCode()==404
2 participants