Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent automerging pre-1.0.0 versions #51

Conversation

HonkingGoose
Copy link
Contributor

Changes:

  • Add "matchCurrentVersion": "!/^0/", to our "Automerge non-major updates" rule

Context:

Renovate recently automerged a pre-1.x update:

I expected us to block updates like these, because of this quote from our docs: 1

The matchCurrentVersion setting above is a rule to exclude any dependencies which are pre-1.0.0 because those can make breaking changes at any time according to the SemVer spec.

So I copy/pasted the code into our own config. 🙃 But maybe we have good reasons to keep things as they are?

Footnotes

  1. Renovate docs, automerge non-major updates

@viceice
Copy link
Member

viceice commented Jul 29, 2023

we don't need that, because we have good tests which will catch any errors.

@HonkingGoose
Copy link
Contributor Author

Are you sure about that? It's probably easy to miss some stuff by accident, and then automerge a broken update.

Or do you think most of our key dependencies are already fully SemVer stable, so the chance of merging in a broken update is low?

@viceice
Copy link
Member

viceice commented Jul 29, 2023

as far as I know only the hcl2json is the only dependency which is lower than 1.0

@HonkingGoose
Copy link
Contributor Author

Should I add a special rule just for that one package then?

Or do you want to close this PR, and leave things as they are now?

@viceice
Copy link
Member

viceice commented Jul 31, 2023

let's leave as is

@viceice viceice closed this Jul 31, 2023
@HonkingGoose HonkingGoose deleted the chore/prevent-automerging-pre-1-versions branch July 31, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants