-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bundle databases with package #88
Conversation
22a4e73
to
b541a1a
Compare
@Churro I'd appreciate your review here too 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we bundle the database, we always need a new renovate release to get latest db.
this is the same issue like we currently have with the azure pipeline tasks.
I'll add a new idea to the issue
That's not the intention of this change. The bundled database is designed to be a fallback if we're unable to download the latest database. For example if the GitHub API is down, or there are other network issues, we can fallback to a stale version of the database. It might not be the most up-to-date, but it is better than nothing. |
I appreciate the idea, as it adds resilience to download errors due to rate limiting or unavailability. However, I'm not yet enirely convinced it will work as intended:
Please correct me if I'm overlooking something here. |
ok, but it'll also blow up a lot. so we should weight that too. @rarkins WDYT? |
b541a1a
to
4d6b26b
Compare
I use Renovate as a dependency downstream so would prefer to avoid any major increase in install size. |
It would add ~7MB to the install size. |
Really seems too much. Can you publish two packages - slim and full and Renovate uses the slim? |
No worries, I'll just close this instead. |
Closes #39
This is hard to test without running
semantic-release
locally, but when running the prepack script manually the databases are included in thedist
directory: