fix(gomod): support .git indicator on private ee gitlab

renovatebot · Aug 10, 2022 · 2aff74a · 2aff74a
1 parent 6f324e4
commit 2aff74a
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 0 deletions.
diff --git a/lib/modules/datasource/go/__fixtures__/go-get-gitlab-ee-private-subgroup.html b/lib/modules/datasource/go/__fixtures__/go-get-gitlab-ee-private-subgroup.html
@@ -0,0 +1,10 @@
+<html>
+<head>
+	<meta name="go-import" content="my.custom.domain/golang/subgroup git https://my.custom.domain/golang/subgroup.git" />
+	<meta name="go-source"
+		content="my.custom.domain/golang/subgroup https://my.custom.domain/golang/subgroup https://my.custom.domain/golang/subgroup/-/tree/master{/dir} https://my.custom.domain/golang/subgroup/-/blob/master{/dir}/{file}#L{line}" />
+</head>
+
+<body>go get https://my.custom.domain/golang/subgroup</body>
+
+</html>
diff --git a/lib/modules/datasource/go/base.spec.ts b/lib/modules/datasource/go/base.spec.ts
@@ -238,6 +238,24 @@ describe('modules/datasource/go/base', () => {
         });
       });
 
+      it('supports GitLab EE deps in private subgroup with vcs indicator', async () => {
+        hostRules.find.mockReturnValue({ token: 'some-token' });
+        httpMock
+          .scope('https://my.custom.domain')
+          .get('/golang/subgroup/myrepo.git/v2?go-get=1')
+          .reply(200, Fixtures.get('go-get-gitlab-ee-private-subgroup.html'));
+
+        const res = await BaseGoDatasource.getDatasource(
+          'my.custom.domain/golang/subgroup/myrepo.git/v2'
+        );
+
+        expect(res).toEqual({
+          datasource: GitlabTagsDatasource.id,
+          packageName: 'golang/subgroup/myrepo',
+          registryUrl: 'https://my.custom.domain',
+        });
+      });
+
       it('supports GitLab EE monorepo deps in subgroup', async () => {
         hostRules.find.mockReturnValue({ token: 'some-token' });
         httpMock

diff --git a/lib/modules/datasource/go/base.ts b/lib/modules/datasource/go/base.ts
@@ -149,6 +149,19 @@ export class BaseGoDatasource {
 
       const registryUrl = `${parsedUrl.protocol}//${parsedUrl.host}`;
 
+      if (goModule.includes('.git')) {
+        // .git indicates a concrete git repository, which can be different from metadata returned by gitlab
+        const directUrl = URL.parse(`https://${goModule}`);
+        return {
+          datasource: GitlabTagsDatasource.id,
+          registryUrl,
+          packageName: `${directUrl.pathname}`.substring(
+            1,
+            `${directUrl.pathname}`.indexOf('.git')
+          ),
+        };
+      }
+
       return {
         datasource: GitlabTagsDatasource.id,
         registryUrl,