fix(config): validate matchStrings (#12808)

renovatebot · Nov 23, 2021 · 2f1c8af · 2f1c8af
1 parent 95fdd83
commit 2f1c8af
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/lib/config/validation.spec.ts b/lib/config/validation.spec.ts
@@ -308,7 +308,7 @@ describe('config/validation', () => {
       expect(errors).toMatchInlineSnapshot(`
         Array [
           Object {
-            "message": "Each Regex Manager must contain a fileMatch array",
+            "message": "Each Regex Manager must contain a non-empty fileMatch array",
             "topic": "Configuration Error",
           },
         ]
@@ -318,21 +318,28 @@ describe('config/validation', () => {
       const config = {
         regexManagers: [
           {
-            fileMatch: [],
+            fileMatch: ['foo'],
             matchStrings: [],
           },
+          {
+            fileMatch: ['foo'],
+          },
         ],
       };
       const { warnings, errors } = await configValidation.validateConfig(
-        config,
+        config as RenovateConfig,
         true
       );
       expect(warnings).toHaveLength(0);
-      expect(errors).toHaveLength(1);
+      expect(errors).toHaveLength(2);
       expect(errors).toMatchInlineSnapshot(`
         Array [
           Object {
-            "message": "Each Regex Manager must contain a fileMatch array",
+            "message": "Each Regex Manager must contain a non-empty matchStrings array",
+            "topic": "Configuration Error",
+          },
+          Object {
+            "message": "Each Regex Manager must contain a non-empty matchStrings array",
             "topic": "Configuration Error",
           },
         ]

diff --git a/lib/config/validation.ts b/lib/config/validation.ts
@@ -443,11 +443,16 @@ export async function validateConfig(
                         }
                       }
                     }
+                  } else {
+                    errors.push({
+                      topic: 'Configuration Error',
+                      message: `Each Regex Manager must contain a non-empty matchStrings array`,
+                    });
                   }
                 } else {
                   errors.push({
                     topic: 'Configuration Error',
-                    message: `Each Regex Manager must contain a fileMatch array`,
+                    message: `Each Regex Manager must contain a non-empty fileMatch array`,
                   });
                 }
               }