Skip to content

Commit

Permalink
feat(migrations): upgradeInRange (#13734)
Browse files Browse the repository at this point in the history
* feat(migrations): upgradeInRange

* feat(migrations): add test case

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
  • Loading branch information
pret-a-porter and viceice committed Jan 22, 2022
1 parent f8124bd commit 34f4901
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 5 deletions.
5 changes: 0 additions & 5 deletions lib/config/migration.ts
Expand Up @@ -174,11 +174,6 @@ export function migrateConfig(
const templateIndex = val.indexOf(`{{`);
migratedConfig.branchPrefix = val.substring(0, templateIndex);
migratedConfig.additionalBranchPrefix = val.substring(templateIndex);
} else if (key === 'upgradeInRange') {
delete migratedConfig.upgradeInRange;
if (val === true) {
migratedConfig.rangeStrategy = 'bump';
}
} else if (key === 'versionStrategy') {
delete migratedConfig.versionStrategy;
if (val === 'widen') {
Expand Down
23 changes: 23 additions & 0 deletions lib/config/migrations/custom/upgrade-in-range-migration.spec.ts
@@ -0,0 +1,23 @@
import { UpgradeInRangeMigration } from './upgrade-in-range-migration';

describe('config/migrations/custom/upgrade-in-range-migration', () => {
it('should migrate upgradeInRange=true to rangeStrategy="bump"', () => {
expect(UpgradeInRangeMigration).toMigrate(
{
upgradeInRange: true,
},
{
rangeStrategy: 'bump',
}
);
});

it('should just remove property when upgradeInRange not equals to true', () => {
expect(UpgradeInRangeMigration).toMigrate(
{
upgradeInRange: false,
},
{}
);
});
});
12 changes: 12 additions & 0 deletions lib/config/migrations/custom/upgrade-in-range-migration.ts
@@ -0,0 +1,12 @@
import { AbstractMigration } from '../base/abstract-migration';

export class UpgradeInRangeMigration extends AbstractMigration {
override readonly deprecated = true;
readonly propertyName = 'upgradeInRange';

override run(value): void {
if (value === true) {
this.setSafely('rangeStrategy', 'bump');
}
}
}
2 changes: 2 additions & 0 deletions lib/config/migrations/migrations-service.ts
Expand Up @@ -12,6 +12,7 @@ import { RebaseStalePrsMigration } from './custom/rebase-stale-prs-migration';
import { RequiredStatusChecksMigration } from './custom/required-status-checks-migration';
import { SemanticCommitsMigration } from './custom/semantic-commits-migration';
import { TrustLevelMigration } from './custom/trust-level-migration';
import { UpgradeInRangeMigration } from './custom/upgrade-in-range-migration';
import type { Migration, MigrationConstructor } from './types';

export class MigrationsService {
Expand Down Expand Up @@ -51,6 +52,7 @@ export class MigrationsService {
RequiredStatusChecksMigration,
SemanticCommitsMigration,
TrustLevelMigration,
UpgradeInRangeMigration,
];

static run(originalConfig: RenovateConfig): RenovateConfig {
Expand Down

0 comments on commit 34f4901

Please sign in to comment.