Skip to content

Commit

Permalink
refactor: remove more instances of 'master issue' (#10426)
Browse files Browse the repository at this point in the history
  • Loading branch information
JamieMagee committed Jun 14, 2021
1 parent 39c0796 commit 3a9fc4f
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 10 deletions.
18 changes: 15 additions & 3 deletions lib/config/presets/__snapshots__/index.spec.ts.snap
Expand Up @@ -67,9 +67,21 @@ exports[`config/presets/index getPreset handles preset not found 3`] = `undefine

exports[`config/presets/index getPreset handles removed presets with a migration 1`] = `
Object {
"dependencyDashboard": true,
"description": Array [
"Enable Renovate Dependency Dashboard creation",
"extends": Array [
":separateMajorReleases",
":combinePatchMinorReleases",
":ignoreUnstable",
":prImmediately",
":semanticPrefixFixDepsChoreOthers",
":updateNotScheduled",
":automergeDisabled",
":ignoreModulesAndTests",
":autodetectPinVersions",
":prHourlyLimit2",
":prConcurrentLimit20",
"group:monorepos",
"group:recommended",
"workarounds:all",
],
}
`;
Expand Down
2 changes: 1 addition & 1 deletion lib/config/presets/index.spec.ts
Expand Up @@ -394,7 +394,7 @@ describe(getName(), () => {
});
describe('getPreset', () => {
it('handles removed presets with a migration', async () => {
const res = await presets.getPreset(':masterIssue', {});
const res = await presets.getPreset(':base', {});
expect(res).toMatchSnapshot();
});
it('handles removed presets with no migration', async () => {
Expand Down
@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`workers/repository/dependency-dashboard ensureMasterIssue() contains logged problems 1`] = `
exports[`workers/repository/dependency-dashboard ensureDependencyDashboard() contains logged problems 1`] = `
"This issue contains a list of Renovate updates and their statuses.
## Repository problems
Expand All @@ -22,7 +22,7 @@ These updates await pending status checks. To force their creation now, check th
"
`;

exports[`workers/repository/dependency-dashboard ensureMasterIssue() open or update Dependency Dashboard when all branches are closed and dependencyDashboardAutoclose is false 1`] = `
exports[`workers/repository/dependency-dashboard ensureDependencyDashboard() open or update Dependency Dashboard when all branches are closed and dependencyDashboardAutoclose is false 1`] = `
"This issue contains a list of Renovate updates and their statuses.
This repository currently has no open or pending branches.
Expand All @@ -32,7 +32,7 @@ And this is a footer
"
`;

exports[`workers/repository/dependency-dashboard ensureMasterIssue() open or update Dependency Dashboard when rules contain approvals 1`] = `
exports[`workers/repository/dependency-dashboard ensureDependencyDashboard() open or update Dependency Dashboard when rules contain approvals 1`] = `
"This issue contains a list of Renovate updates and their statuses.
This repository currently has no open or pending branches.
Expand Down
6 changes: 3 additions & 3 deletions lib/workers/repository/dependency-dashboard.spec.ts
Expand Up @@ -42,11 +42,11 @@ async function dryRun(
}

describe(getName(), () => {
describe('ensureMasterIssue()', () => {
describe('ensureDependencyDashboard()', () => {
beforeEach(() => {
setAdminConfig();
});
it('do nothing if masterissue is disable', async () => {
it('do nothing if dependencyDashboard is disabled', async () => {
const branches: BranchConfig[] = [];
await dependencyDashboard.ensureDependencyDashboard(config, branches);
expect(platform.ensureIssueClosing).toHaveBeenCalledTimes(0);
Expand All @@ -56,7 +56,7 @@ describe(getName(), () => {
await dryRun(branches, platform);
});

it('do nothing if it has no masterissueapproval branches', async () => {
it('do nothing if it has no dependencyDashboardApproval branches', async () => {
const branches = [
{
...mock<BranchConfig>(),
Expand Down

0 comments on commit 3a9fc4f

Please sign in to comment.