fix(npm): Migrate unpublishSafe presets (#7983)

renovatebot · Dec 13, 2020 · 3d48283 · 3d48283
1 parent eaf3f78
commit 3d48283
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/lib/config/migration.spec.ts b/lib/config/migration.spec.ts
@@ -514,7 +514,7 @@ describe('config/migration', () => {
       res = configMigration.migrateConfig(config);
       expect(res.isMigrated).toBe(true);
       expect(res.migratedConfig).toMatchObject({
-        extends: ['foo', ':unpublishSafe', 'bar', 'npm:unpublishSafe'],
+        extends: ['foo', 'npm:unpublishSafe', 'bar'],
       });
 
       config = {
@@ -524,7 +524,7 @@ describe('config/migration', () => {
       res = configMigration.migrateConfig(config);
       expect(res.isMigrated).toBe(true);
       expect(res.migratedConfig).toMatchObject({
-        extends: ['foo', 'default:unpublishSafe', 'bar', 'npm:unpublishSafe'],
+        extends: ['foo', 'npm:unpublishSafe', 'bar'],
       });
 
       config = {

diff --git a/lib/config/migration.ts b/lib/config/migration.ts
@@ -229,6 +229,10 @@ export function migrateConfig(
               preset = 'config:js-lib';
             } else if (preset.startsWith(':masterIssue')) {
               preset = preset.replace('masterIssue', 'dependencyDashboard');
+            } else if (
+              [':unpublishSafe', 'default:unpublishSafe'].includes(preset)
+            ) {
+              preset = 'npm:unpublishSafe';
             }
             presets[i] = preset;
           }
@@ -239,7 +243,13 @@ export function migrateConfig(
           if (is.string(migratedConfig.extends)) {
             migratedConfig.extends = [migratedConfig.extends];
           }
-          if (!migratedConfig.extends.includes('npm:unpublishSafe')) {
+          if (
+            ![
+              ':unpublishSafe',
+              'default:unpublishSafe',
+              'npm:unpublishSafe',
+            ].some((x) => migratedConfig.extends.includes(x))
+          ) {
             migratedConfig.extends.push('npm:unpublishSafe');
           }
         }

diff --git a/lib/config/presets/internal/default.ts b/lib/config/presets/internal/default.ts
@@ -584,7 +584,4 @@ export const presets: Record<string, Preset> = {
     description: 'deprecated alias for config:js-lib',
     extends: ['config:js-lib'],
   },
-  unpublishSafe: {
-    extends: ['npm:unpublishSafe'],
-  },
 };