fix(gomod): remove token encoding (#12352)

Co-authored-by: Rhys Arkins <rhys@arkins.net>
renovatebot · Oct 27, 2021 · 53964d1 · 53964d1
1 parent 91f067b
commit 53964d1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/util/git/auth.spec.ts b/lib/util/git/auth.spec.ts
@@ -18,14 +18,15 @@ describe('util/git/auth', () => {
       });
     });
 
-    it('returns url with correctly encoded token', () => {
+    it('returns correct url if token already contains GitHub App username', () => {
       expect(
         getGitAuthenticatedEnvironmentVariables(
           'https://github.com/',
-          'token:1234'
+          'x-access-token:token1234'
         )
       ).toStrictEqual({
-        GIT_CONFIG_KEY_0: 'url.https://token%3A1234@github.com/.insteadOf',
+        GIT_CONFIG_KEY_0:
+          'url.https://x-access-token:token1234@github.com/.insteadOf',
         GIT_CONFIG_VALUE_0: 'https://github.com/',
         GIT_CONFIG_COUNT: '1',
       });

diff --git a/lib/util/git/auth.ts b/lib/util/git/auth.ts
@@ -24,7 +24,7 @@ export function getGitAuthenticatedEnvironmentVariables(
     }
   }
 
-  const gitUrlWithToken = getHttpUrl(gitUrl, encodeURIComponent(token));
+  const gitUrlWithToken = getHttpUrl(gitUrl, token);
 
   // create a shallow copy of the environmentVariables as base so we don't modify the input parameter object
   // add the two new config key and value to the returnEnvironmentVariables object