fix: Revert "feat: helm-values manager (#5134)"

This reverts commit edf85d4.
renovatebot · Feb 4, 2020 · 58fd656 · 58fd656
1 parent edf85d4
commit 58fd656
Show file tree

Hide file tree

Showing 18 changed files with 9 additions and 582 deletions.
diff --git a/docs/usage/configuration-options.md b/docs/usage/configuration-options.md
@@ -483,19 +483,6 @@ Note: you shouldn't usually need to configure this unless you really care about
 
 Renovate supports updating Helm Chart references within `requirements.yaml` files. If your Helm charts make use of Aliases then you will need to configure an `aliases` object in your config to tell Renovate where to look for them.
 
-## helm-values
-
-Renovate supports updating of Docker dependencies within Helm Chart `values.yaml` files or other YAML
-files that use the same format (via `fileMatch` configuration). Updates are performed if the files
-follow the conventional format used in most of the `stable` Helm charts:
-
-```yaml
-image:
-  repository: 'some-docker/dependency'
-  tag: v1.0.0
-  registry: registry.example.com # optional key, will default to "docker.io"
-```
-
 ## helmfile
 
 ## homebrew

diff --git a/lib/config/definitions.ts b/lib/config/definitions.ts
@@ -1753,18 +1753,6 @@ const options: RenovateOptions[] = [
     mergeable: true,
     cli: false,
   },
-  {
-    name: 'helm-values',
-    description: 'Configuration object for helm values.yaml files.',
-    stage: 'package',
-    type: 'object',
-    default: {
-      commitMessageTopic: 'helm values {{depName}}',
-      fileMatch: ['(^|/)values.yaml$'],
-    },
-    mergeable: true,
-    cli: false,
-  },
   {
     name: 'helmfile',
     description: 'Configuration object for helmfile helmfile.yaml files.',

diff --git a/lib/manager/common.ts b/lib/manager/common.ts
@@ -148,7 +148,6 @@ export interface Upgrade<T = Record<string, any>>
   checksumUrl?: string;
   currentVersion?: string;
   depGroup?: string;
-  dockerRepository?: string;
   downloadUrl?: string;
   localDir?: string;
   name?: string;

diff --git a/lib/manager/helm-values/extract.ts b/lib/manager/helm-values/extract.ts
diff --git a/lib/manager/helm-values/index.ts b/lib/manager/helm-values/index.ts
diff --git a/lib/manager/helm-values/update.ts b/lib/manager/helm-values/update.ts
diff --git a/lib/manager/helm-values/util.ts b/lib/manager/helm-values/util.ts
diff --git a/renovate-schema.json b/renovate-schema.json
@@ -1165,15 +1165,6 @@
       },
       "$ref": "#"
     },
-    "helm-values": {
-      "description": "Configuration object for helm values.yaml files.",
-      "type": "object",
-      "default": {
-        "commitMessageTopic": "helm values {{depName}}",
-        "fileMatch": ["(^|/)values.yaml$"]
-      },
-      "$ref": "#"
-    },
     "helmfile": {
       "description": "Configuration object for helmfile helmfile.yaml files.",
       "type": "object",

diff --git a/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap b/test/manager/helm-requirements/__snapshots__/extract.spec.ts.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`lib/manager/helm-requirements/extract extractPackageFile() parses simple requirements.yaml correctly 1`] = `
+exports[`lib/manager/helm/extract extractPackageFile() parses simple requirements.yaml correctly 1`] = `
 Object {
   "datasource": "helm",
   "deps": Array [
@@ -22,7 +22,7 @@ Object {
 }
 `;
 
-exports[`lib/manager/helm-requirements/extract extractPackageFile() resolves aliased registry urls 1`] = `
+exports[`lib/manager/helm/extract extractPackageFile() resolves aliased registry urls 1`] = `
 Object {
   "datasource": "helm",
   "deps": Array [
@@ -37,7 +37,7 @@ Object {
 }
 `;
 
-exports[`lib/manager/helm-requirements/extract extractPackageFile() skips invalid registry urls 1`] = `
+exports[`lib/manager/helm/extract extractPackageFile() skips invalid registry urls 1`] = `
 Object {
   "datasource": "helm",
   "deps": Array [
@@ -66,7 +66,7 @@ Object {
 }
 `;
 
-exports[`lib/manager/helm-requirements/extract extractPackageFile() skips local dependencies 1`] = `
+exports[`lib/manager/helm/extract extractPackageFile() skips local dependencies 1`] = `
 Object {
   "datasource": "helm",
   "deps": Array [

diff --git a/test/manager/helm-requirements/__snapshots__/update.spec.ts.snap b/test/manager/helm-requirements/__snapshots__/update.spec.ts.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`lib/manager/helm-requirements/update updateDependency() upgrades dependency if newValue version value is repeated 1`] = `
+exports[`lib/manager/helm/extract updateDependency() upgrades dependency if newValue version value is repeated 1`] = `
 "
       dependencies:
         - version: 0.9.0
@@ -12,7 +12,7 @@ exports[`lib/manager/helm-requirements/update updateDependency() upgrades depend
       "
 `;
 
-exports[`lib/manager/helm-requirements/update updateDependency() upgrades dependency if valid upgrade 1`] = `
+exports[`lib/manager/helm/extract updateDependency() upgrades dependency if valid upgrade 1`] = `
 "
       dependencies:
         - name: redis
@@ -24,7 +24,7 @@ exports[`lib/manager/helm-requirements/update updateDependency() upgrades depend
       "
 `;
 
-exports[`lib/manager/helm-requirements/update updateDependency() upgrades dependency if version field comes before name field 1`] = `
+exports[`lib/manager/helm/extract updateDependency() upgrades dependency if version field comes before name field 1`] = `
 "
       dependencies:
         - version: 0.11.0

diff --git a/test/manager/helm-requirements/extract.spec.ts b/test/manager/helm-requirements/extract.spec.ts
@@ -3,7 +3,7 @@ import { platform as _platform } from '../../../lib/platform';
 
 const platform: any = _platform;
 
-describe('lib/manager/helm-requirements/extract', () => {
+describe('lib/manager/helm/extract', () => {
   describe('extractPackageFile()', () => {
     beforeEach(() => {
       jest.resetAllMocks();

diff --git a/test/manager/helm-requirements/update.spec.ts b/test/manager/helm-requirements/update.spec.ts
@@ -1,6 +1,6 @@
 import { updateDependency } from '../../../lib/manager/helm-requirements/update';
 
-describe('lib/manager/helm-requirements/update', () => {
+describe('lib/manager/helm/extract', () => {
   describe('updateDependency()', () => {
     it('returns the same fileContent for undefined upgrade', () => {
       const content = `