refactor(gitlab): Support state changes for updatePr (#7013)

renovatebot · Aug 18, 2020 · 6f7cced · 6f7cced
1 parent b0102b6
commit 6f7cced
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 0 deletions.
diff --git a/lib/platform/gitlab/__snapshots__/index.spec.ts.snap b/lib/platform/gitlab/__snapshots__/index.spec.ts.snap
@@ -1742,6 +1742,25 @@ Array [
 ]
 `;
 
+exports[`platform/gitlab updatePr(prNo, title, body) closes the PR 1`] = `
+Array [
+  Object {
+    "body": "{\\"title\\":\\"title\\",\\"description\\":\\"body\\",\\"state_event\\":\\"closed\\"}",
+    "headers": Object {
+      "accept": "application/json",
+      "accept-encoding": "gzip, deflate",
+      "content-length": "61",
+      "content-type": "application/json",
+      "host": "gitlab.com",
+      "private-token": "abc123",
+      "user-agent": "https://github.com/renovatebot/renovate",
+    },
+    "method": "PUT",
+    "url": "https://gitlab.com/api/v4/projects/undefined/merge_requests/1",
+  },
+]
+`;
+
 exports[`platform/gitlab updatePr(prNo, title, body) updates the PR 1`] = `
 Array [
   Object {

diff --git a/lib/platform/gitlab/index.spec.ts b/lib/platform/gitlab/index.spec.ts
@@ -1120,6 +1120,19 @@ describe('platform/gitlab', () => {
       await gitlab.updatePr({ number: 1, prTitle: 'title', prBody: 'body' });
       expect(httpMock.getTrace()).toMatchSnapshot();
     });
+    it('closes the PR', async () => {
+      httpMock
+        .scope(gitlabApiHost)
+        .put('/api/v4/projects/undefined/merge_requests/1')
+        .reply(200);
+      await gitlab.updatePr({
+        number: 1,
+        prTitle: 'title',
+        prBody: 'body',
+        state: PrState.Closed,
+      });
+      expect(httpMock.getTrace()).toMatchSnapshot();
+    });
   });
   describe('mergePr(pr)', () => {
     jest.resetAllMocks();

diff --git a/lib/platform/gitlab/index.ts b/lib/platform/gitlab/index.ts
@@ -475,13 +475,19 @@ export async function updatePr({
   number: iid,
   prTitle: title,
   prBody: description,
+  state,
 }: UpdatePrConfig): Promise<void> {
+  const newState = {
+    [PrState.Closed]: 'closed',
+    [PrState.Open]: 'reopen',
+  }[state];
   await gitlabApi.putJson(
     `projects/${config.repository}/merge_requests/${iid}`,
     {
       body: {
         title,
         description: sanitize(description),
+        ...(newState && { state_event: newState }),
       },
     }
   );