refactor(platform): pass CommitFilesConfig through

renovatebot · Jun 2, 2020 · 75c0ca6 · 75c0ca6
1 parent 6516cc1
commit 75c0ca6
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 62 deletions.
diff --git a/lib/platform/bitbucket-server/index.ts b/lib/platform/bitbucket-server/index.ts
@@ -443,32 +443,15 @@ export function getAllRenovateBranches(
   return config.storage.getAllRenovateBranches(branchPrefix);
 }
 
-export async function commitFiles({
-  branchName,
-  files,
-  message,
-}: CommitFilesConfig): Promise<string | null> {
-  logger.debug(
-    `commitFiles(${JSON.stringify(
-      {
-        branchName,
-        filesLength: files.length,
-        message,
-      },
-      null,
-      2
-    )})`
-  );
-  const commit = config.storage.commitFiles({
-    branchName,
-    files,
-    message,
-  });
+export async function commitFiles(
+  commitFilesConfig: CommitFilesConfig
+): Promise<string | null> {
+  const commit = config.storage.commitFiles(commitFilesConfig);
 
   // wait for pr change propagation
   await delay(1000);
   // refresh cache
-  await getBranchPr(branchName, true);
+  await getBranchPr(commitFilesConfig.branchName, true);
   return commit;
 }
 

diff --git a/lib/platform/bitbucket/index.ts b/lib/platform/bitbucket/index.ts
@@ -295,16 +295,11 @@ export function mergeBranch(branchName: string): Promise<void> {
   return config.storage.mergeBranch(branchName);
 }
 
-export function commitFiles({
-  branchName,
-  files,
-  message,
-}: CommitFilesConfig): Promise<string | null> {
-  return config.storage.commitFiles({
-    branchName,
-    files,
-    message,
-  });
+// istanbul ignore next
+export function commitFiles(
+  commitFilesConfig: CommitFilesConfig
+): Promise<string | null> {
+  return config.storage.commitFiles(commitFilesConfig);
 }
 
 export function getCommitMessages(): Promise<string[]> {

diff --git a/lib/platform/gitea/index.ts b/lib/platform/gitea/index.ts
@@ -865,16 +865,8 @@ const platform: Platform = {
     return Promise.resolve();
   },
 
-  commitFiles({
-    branchName,
-    files,
-    message,
-  }: CommitFilesConfig): Promise<string | null> {
-    return config.storage.commitFiles({
-      branchName,
-      files,
-      message,
-    });
+  commitFiles(commitFilesConfig: CommitFilesConfig): Promise<string | null> {
+    return config.storage.commitFiles(commitFilesConfig);
   },
 
   getPrBody(prBody: string): string {

diff --git a/lib/platform/github/index.ts b/lib/platform/github/index.ts
@@ -568,16 +568,10 @@ export function mergeBranch(branchName: string): Promise<void> {
 }
 
 // istanbul ignore next
-export function commitFiles({
-  branchName,
-  files,
-  message,
-}: CommitFilesConfig): Promise<string | null> {
-  return config.storage.commitFiles({
-    branchName,
-    files,
-    message,
-  });
+export function commitFiles(
+  commitFilesConfig: CommitFilesConfig
+): Promise<string | null> {
+  return config.storage.commitFiles(commitFilesConfig);
 }
 
 // istanbul ignore next

diff --git a/lib/platform/gitlab/index.ts b/lib/platform/gitlab/index.ts
@@ -632,16 +632,11 @@ export function isBranchStale(branchName: string): Promise<boolean> {
   return config.storage.isBranchStale(branchName);
 }
 
-export function commitFiles({
-  branchName,
-  files,
-  message,
-}: CommitFilesConfig): Promise<string | null> {
-  return config.storage.commitFiles({
-    branchName,
-    files,
-    message,
-  });
+// istanbul ignore next
+export function commitFiles(
+  commitFilesConfig: CommitFilesConfig
+): Promise<string | null> {
+  return config.storage.commitFiles(commitFilesConfig);
 }
 
 export function getFile(