refactor(cdnurl): use autoReplace (#5909)

renovatebot · Apr 7, 2020 · 808d509 · 808d509
1 parent ccf9061
commit 808d509
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 120 deletions.
diff --git a/lib/manager/cdnurl/__snapshots__/extract.spec.ts.snap b/lib/manager/cdnurl/__snapshots__/extract.spec.ts.snap
@@ -8,90 +8,60 @@ Object {
       "datasource": "cdnjs",
       "depName": "prop-types",
       "lookupName": "prop-types/prop-types.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 51,
-      },
     },
     Object {
       "currentValue": "16.3.2",
       "datasource": "cdnjs",
       "depName": "react",
       "lookupName": "react/umd/react.production.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 115,
-      },
     },
     Object {
       "currentValue": "16.3.2",
       "datasource": "cdnjs",
       "depName": "react-dom",
       "lookupName": "react-dom/umd/react-dom.production.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 199,
-      },
     },
     Object {
       "currentValue": "2.2.1",
       "datasource": "cdnjs",
       "depName": "react-transition-group",
       "lookupName": "react-transition-group/react-transition-group.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 351,
-      },
     },
     Object {
       "currentValue": "1.14.3",
       "datasource": "cdnjs",
       "depName": "popper.js",
       "lookupName": "popper.js/umd/popper.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 436,
-      },
     },
     Object {
       "currentValue": "0.10.4",
       "datasource": "cdnjs",
       "depName": "react-popper",
       "lookupName": "react-popper/umd/react-popper.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 513,
-      },
     },
     Object {
       "currentValue": "7.1.0",
       "datasource": "cdnjs",
       "depName": "reactstrap",
       "lookupName": "reactstrap/reactstrap.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 594,
-      },
     },
     Object {
       "currentValue": "4.3.1",
       "datasource": "cdnjs",
       "depName": "react-router",
       "lookupName": "react-router/react-router.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 670,
-      },
     },
     Object {
       "currentValue": "4.0.6",
       "datasource": "cdnjs",
       "depName": "react-markdown",
       "lookupName": "react-markdown/react-markdown.js",
-      "managerData": Object {
-        "fileReplacePosition": 750,
-      },
     },
     Object {
       "currentValue": "0.18.0",
       "datasource": "cdnjs",
       "depName": "axios",
       "lookupName": "axios/axios.min.js",
-      "managerData": Object {
-        "fileReplacePosition": 888,
-      },
     },
   ],
 }

diff --git a/lib/manager/cdnurl/extract.ts b/lib/manager/cdnurl/extract.ts
@@ -12,10 +12,6 @@ export function extractPackageFile(content: string): PackageFile {
   while (match) {
     const [wholeSubstr] = match;
     const { depName, currentValue, asset } = match.groups;
-
-    const fileReplacePosition =
-      offset + match.index + wholeSubstr.indexOf(currentValue);
-
     offset += match.index + wholeSubstr.length;
     rest = content.slice(offset);
     match = cloudflareUrlRegex.exec(rest);
@@ -25,9 +21,6 @@ export function extractPackageFile(content: string): PackageFile {
       depName,
       lookupName: `${depName}/${asset}`,
       currentValue,
-      managerData: {
-        fileReplacePosition,
-      },
     });
   }
 

diff --git a/lib/manager/cdnurl/index.ts b/lib/manager/cdnurl/index.ts
@@ -1,8 +1,9 @@
 import * as semverVersioning from '../../versioning/semver';
 import { extractPackageFile } from './extract';
-import { updateDependency } from './update';
 
-export { extractPackageFile, updateDependency };
+export { extractPackageFile };
+
+export const autoReplace = true;
 
 export const defaultConfig = {
   fileMatch: [],

diff --git a/lib/manager/cdnurl/update.spec.ts b/lib/manager/cdnurl/update.spec.ts
diff --git a/lib/manager/cdnurl/update.ts b/lib/manager/cdnurl/update.ts