fix(terraform): check for missing version provider blocks (#12962)

renovatebot · Dec 5, 2021 · 87abbeb · 87abbeb
1 parent 99749f1
commit 87abbeb
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/lib/manager/terraform/__snapshots__/extract.spec.ts.snap b/lib/manager/terraform/__snapshots__/extract.spec.ts.snap
@@ -212,6 +212,7 @@ Object {
       "depType": "provider",
       "lockedVersion": undefined,
       "lookupName": "hashicorp/helm",
+      "skipReason": "no-version",
     },
     Object {
       "currentValue": "V1.9",

diff --git a/lib/manager/terraform/extract.spec.ts b/lib/manager/terraform/extract.spec.ts
@@ -36,7 +36,7 @@ describe('manager/terraform/extract', () => {
       const res = await extractPackageFile(tf1, '1.tf', {});
       expect(res).toMatchSnapshot();
       expect(res.deps).toHaveLength(51);
-      expect(res.deps.filter((dep) => dep.skipReason)).toHaveLength(8);
+      expect(res.deps.filter((dep) => dep.skipReason)).toHaveLength(9);
     });
 
     it('returns null if only local deps', async () => {

diff --git a/lib/manager/terraform/providers.ts b/lib/manager/terraform/providers.ts
@@ -99,4 +99,8 @@ export function analyzeTerraformProvider(
   massageProviderLookupName(dep);
 
   dep.lockedVersion = getLockedVersion(dep, locks);
+
+  if (!dep.currentValue) {
+    dep.skipReason = SkipReason.NoVersion;
+  }
 }