Skip to content

Commit

Permalink
feat(gitlab): use server side archived filter (#17358)
Browse files Browse the repository at this point in the history
  • Loading branch information
viceice committed Aug 23, 2022
1 parent 229643f commit 8f8f059
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
8 changes: 2 additions & 6 deletions lib/modules/platform/gitlab/index.spec.ts
Expand Up @@ -136,7 +136,7 @@ describe('modules/platform/gitlab/index', () => {
httpMock
.scope(gitlabApiHost)
.get(
'/api/v4/projects?membership=true&per_page=100&with_merge_requests_enabled=true&min_access_level=30'
'/api/v4/projects?membership=true&per_page=100&with_merge_requests_enabled=true&min_access_level=30&archived=false'
)
.replyWithError('getRepos error');
await expect(gitlab.getRepos()).rejects.toThrow('getRepos error');
Expand All @@ -146,7 +146,7 @@ describe('modules/platform/gitlab/index', () => {
httpMock
.scope(gitlabApiHost)
.get(
'/api/v4/projects?membership=true&per_page=100&with_merge_requests_enabled=true&min_access_level=30'
'/api/v4/projects?membership=true&per_page=100&with_merge_requests_enabled=true&min_access_level=30&archived=false'
)
.reply(200, [
{
Expand All @@ -155,10 +155,6 @@ describe('modules/platform/gitlab/index', () => {
{
path_with_namespace: 'c/d',
},
{
path_with_namespace: 'c/e',
archived: true,
},
{
path_with_namespace: 'c/f',
mirror: true,
Expand Down
4 changes: 2 additions & 2 deletions lib/modules/platform/gitlab/index.ts
Expand Up @@ -143,13 +143,13 @@ export async function initPlatform({
export async function getRepos(): Promise<string[]> {
logger.debug('Autodiscovering GitLab repositories');
try {
const url = `projects?membership=true&per_page=100&with_merge_requests_enabled=true&min_access_level=30`;
const url = `projects?membership=true&per_page=100&with_merge_requests_enabled=true&min_access_level=30&archived=false`;
const res = await gitlabApi.getJson<RepoResponse[]>(url, {
paginate: true,
});
logger.debug(`Discovered ${res.body.length} project(s)`);
return res.body
.filter((repo) => !repo.mirror && !repo.archived)
.filter((repo) => !repo.mirror)
.map((repo) => repo.path_with_namespace);
} catch (err) {
logger.error({ err }, `GitLab getRepos error`);
Expand Down

0 comments on commit 8f8f059

Please sign in to comment.