Skip to content

Commit

Permalink
fix(manager/sbt): Support for updating Scala 3 (#19911)
Browse files Browse the repository at this point in the history
  • Loading branch information
aktowns committed Jan 23, 2023
1 parent 7a6d1f0 commit 9eef71a
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 1 deletion.
15 changes: 15 additions & 0 deletions lib/modules/manager/sbt/extract.spec.ts
Expand Up @@ -223,6 +223,21 @@ describe('modules/manager/sbt/extract', () => {
});
});

it('extracts correct scala library when dealing with scala 3', () => {
const content = `
scalaVersion := "3.1.1"
`;

expect(extractPackageFile(content)).toMatchObject({
deps: [
{
packageName: 'org.scala-lang:scala3-library_3',
currentValue: '3.1.1',
},
],
});
});

it('extracts deps when scala version is defined in a variable with ThisBuild scope', () => {
const content = `
val ScalaVersion = "2.12.10"
Expand Down
11 changes: 10 additions & 1 deletion lib/modules/manager/sbt/extract.ts
Expand Up @@ -8,6 +8,8 @@ import {
SBT_PLUGINS_REPO,
SbtPluginDatasource,
} from '../../datasource/sbt-plugin';
import { get } from '../../versioning';
import * as mavenVersioning from '../../versioning/maven';
import { REGISTRY_URLS } from '../gradle/parser/common';
import type { PackageDependency, PackageFile } from '../types';
import { normalizeScalaVersion } from './util';
Expand Down Expand Up @@ -49,10 +51,17 @@ const scalaVersionMatch = q
)
.handler((ctx) => {
if (ctx.scalaVersion) {
const version = get(mavenVersioning.id);

let packageName = 'org.scala-lang:scala-library';
if (version.getMajor(ctx.scalaVersion) === 3) {
packageName = 'org.scala-lang:scala3-library_3';
}

const dep: PackageDependency = {
datasource: MavenDatasource.id,
depName: 'scala',
packageName: 'org.scala-lang:scala-library',
packageName,
currentValue: ctx.scalaVersion,
separateMinorPatch: true,
};
Expand Down

0 comments on commit 9eef71a

Please sign in to comment.