Skip to content

Commit

Permalink
refactor: drop redundant config:base settings
Browse files Browse the repository at this point in the history
  • Loading branch information
rarkins committed Aug 17, 2021
1 parent 123dc44 commit a09b85a
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions lib/config/presets/internal/config.ts
Expand Up @@ -4,13 +4,7 @@ export const presets: Record<string, Preset> = {
base: {
description: 'Default base configuration for all languages',
extends: [
':separateMajorReleases',
':combinePatchMinorReleases',
':ignoreUnstable',
':prImmediately',
':semanticPrefixFixDepsChoreOthers',
':updateNotScheduled',
':automergeDisabled',
':ignoreModulesAndTests',
':autodetectPinVersions',
':prHourlyLimit2',
Expand Down

3 comments on commit a09b85a

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to see an explanation in the commit message which serves as reference for current and future research.

What makes these redundant?

@rarkins
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are redundant because they simply reconfirm the default settings. Now config:base is internal to Renovate, it's not possible for them to get out of sync.

@mbrodala
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for the details. 👍

Please sign in to comment.