refactor(typescript): Refactor more files (#12696)

Co-authored-by: Rhys Arkins <rhys@arkins.net>
renovatebot · Nov 17, 2021 · a7792bc · a7792bc
1 parent e95fcb1
commit a7792bc
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 5 deletions.
diff --git a/lib/types/errors/external-host-error.ts b/lib/types/errors/external-host-error.ts
@@ -1,7 +1,7 @@
 import { EXTERNAL_HOST_ERROR } from '../../constants/error-messages';
 
 export class ExternalHostError extends Error {
-  hostType: string;
+  hostType: string | undefined;
 
   err: Error;
 

diff --git a/lib/util/mask.spec.ts b/lib/util/mask.spec.ts
@@ -2,7 +2,8 @@ import { maskToken } from './mask';
 
 describe('util/mask', () => {
   describe('.maskToken', () => {
-    it('returns value if passed value is falsy', () => {
+    it('returns empty string if passed value is falsy', () => {
+      expect(maskToken()).toBe('');
       expect(maskToken('')).toBe('');
     });
 

diff --git a/lib/util/mask.ts b/lib/util/mask.ts
@@ -5,5 +5,5 @@ export function maskToken(str?: string): string {
         new Array(str.length - 3).join('*'),
         str.slice(-2),
       ].join('')
-    : str;
+    : '';
 }
diff --git a/test/graphql-snapshot.ts b/test/graphql-snapshot.ts
@@ -37,11 +37,13 @@ type Variables = Record<string, string>;
 interface SelectionSet {
   __vars?: Variables;
   __args?: Arguments;
-  [key: string]: null | SelectionSet | Arguments;
+  [key: string]: undefined | null | SelectionSet | Arguments;
 }
 
 interface GraphqlSnapshot {
   query?: SelectionSet;
+  mutation?: SelectionSet;
+  subscription?: SelectionSet;
   variables?: Record<string, string>;
 }
 
@@ -81,7 +83,7 @@ function getArguments(key: string, val: ValueNode): Arguments {
 }
 
 function simplifyArguments(
-  argNodes: ReadonlyArray<ArgumentNode>
+  argNodes?: ReadonlyArray<ArgumentNode>
 ): Arguments | null {
   if (argNodes) {
     let result: Arguments = {};

diff --git a/tsconfig.strict.json b/tsconfig.strict.json
@@ -88,6 +88,7 @@
     "./lib/platform/utils/pr-body.ts",
     "./lib/proxy.ts",
     "./lib/types/branch-status.ts",
+    "./lib/types/errors/external-host-error.ts",
     "./lib/types/git.ts",
     "./lib/types/host-rules.ts",
     "./lib/types/later.d.ts",
@@ -108,12 +109,15 @@
     "./lib/util/http/types.ts",
     "./lib/util/index.ts",
     "./lib/util/json-writer/indentation-type.ts",
+    "./lib/util/mask.spec.ts",
+    "./lib/util/mask.ts",
     "./lib/util/object.ts",
     "./lib/util/sanitize.ts",
     "./lib/util/split.ts",
     "./lib/workers/pr/changelog/hbs-template.ts",
     "./lib/workers/pr/changelog/types.ts",
     "./lib/workers/repository/init/types.ts",
+    "./test/graphql-snapshot.ts",
     "./test/json-schema.ts",
     "./test/newline-snapshot-serializer.ts",
     "./test/static-files.spec.ts",