fix(package-rules): matchCurrentVersion with null versioning (#24965)

renovatebot · Oct 3, 2023 · b66df6e · b66df6e
1 parent c8fceec
commit b66df6e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/lib/modules/versioning/index.ts b/lib/modules/versioning/index.ts
@@ -16,8 +16,10 @@ export const getVersionings = (): Map<
   VersioningApi | VersioningApiConstructor
 > => versionings;
 
-export function get(versioning = ''): VersioningApi {
-  const res = Versioning.safeParse(versioning);
+export function get(versioning: string | null | undefined): VersioningApi {
+  const res = Versioning.safeParse(
+    versioning ? versioning : defaultVersioning.id
+  );
 
   if (!res.success) {
     const [issue] = res.error.issues;

diff --git a/lib/util/package-rules/current-version.spec.ts b/lib/util/package-rules/current-version.spec.ts
@@ -5,6 +5,20 @@ describe('util/package-rules/current-version', () => {
   const matcher = new CurrentVersionMatcher();
 
   describe('match', () => {
+    it('returns true for null versioning', () => {
+      const result = matcher.matches(
+        {
+          // @ts-expect-error: for testing
+          versioning: null,
+          currentValue: '1.2.3',
+        },
+        {
+          matchCurrentVersion: '1.2.3',
+        }
+      );
+      expect(result).toBeTrue();
+    });
+
     it('return false on version exception', () => {
       const spy = jest.spyOn(pep440, 'matches').mockImplementationOnce(() => {
         throw new Error();