chore: allow null value and undefined for validateURL (#25014)

renovatebot · Oct 4, 2023 · b73cf03 · b73cf03
1 parent 4670e3b
commit b73cf03
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/util/url.spec.ts b/lib/util/url.spec.ts
@@ -98,8 +98,9 @@ describe('util/url', () => {
   });
 
   it('validates URLs', () => {
-    expect(validateUrl()).toBeFalse();
-    expect(validateUrl(null as never)).toBeFalse();
+    expect(validateUrl(undefined)).toBeFalse();
+    expect(validateUrl('')).toBeFalse();
+    expect(validateUrl(null)).toBeFalse();
     expect(validateUrl('foo')).toBeFalse();
     expect(validateUrl('ssh://github.com')).toBeFalse();
     expect(validateUrl('http://github.com')).toBeTrue();

diff --git a/lib/util/url.ts b/lib/util/url.ts
@@ -85,8 +85,11 @@ export function getQueryString(params: Record<string, any>): string {
   return usp.toString();
 }
 
-export function validateUrl(url?: string, httpOnly = true): boolean {
-  if (!url) {
+export function validateUrl(
+  url: string | null | undefined,
+  httpOnly = true
+): boolean {
+  if (!is.nonEmptyString(url)) {
     return false;
   }
   try {