Skip to content

Commit

Permalink
refactor(config): Extract interfaces from "index.ts" to separate "typ…
Browse files Browse the repository at this point in the history
…es.ts" (#9629)
  • Loading branch information
zharinov committed Apr 20, 2021
1 parent f630963 commit b957d4a
Show file tree
Hide file tree
Showing 54 changed files with 70 additions and 74 deletions.
2 changes: 1 addition & 1 deletion lib/config/decrypt.spec.ts
Expand Up @@ -2,7 +2,7 @@ import fs from 'fs';
import { getName } from '../../test/util';
import { setAdminConfig } from './admin';
import { decryptConfig } from './decrypt';
import { RenovateConfig } from '.';
import type { RenovateConfig } from './types';

const privateKey = fs.readFileSync('lib/config/keys/__fixtures__/private.pem');

Expand Down
7 changes: 1 addition & 6 deletions lib/config/index.ts
Expand Up @@ -10,19 +10,14 @@ import * as fileParser from './file';
import { resolveConfigPresets } from './presets';
import type {
GlobalConfig,
ManagerConfig,
RenovateConfig,
RenovateConfigStage,
} from './types';
import { mergeChildConfig } from './utils';

export * from './types';
export { mergeChildConfig };

export interface ManagerConfig extends RenovateConfig {
language: string;
manager: string;
}

export function getManagerConfig(
config: RenovateConfig,
manager: string
Expand Down
2 changes: 1 addition & 1 deletion lib/config/massage.spec.ts
@@ -1,6 +1,6 @@
import { getName } from '../../test/util';
import * as massage from './massage';
import { RenovateConfig } from '.';
import type { RenovateConfig } from './types';

describe(getName(__filename), () => {
describe('massageConfig', () => {
Expand Down
5 changes: 4 additions & 1 deletion lib/config/migration.spec.ts
Expand Up @@ -3,7 +3,10 @@ import { PLATFORM_TYPE_GITHUB } from '../constants/platforms';
import { getConfig } from './defaults';
import * as configMigration from './migration';
import { MigratedConfig } from './migration';
import { RenovateSharedConfig, RenovateConfig as _RenovateConfig } from '.';
import type {
RenovateSharedConfig,
RenovateConfig as _RenovateConfig,
} from './types';

const defaultConfig = getConfig();

Expand Down
2 changes: 1 addition & 1 deletion lib/config/presets/index.spec.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '..';
import { getName, mocked } from '../../../test/util';
import type { RenovateConfig } from '../types';
import presetIkatyang from './__fixtures__/renovate-config-ikatyang.json';
import * as _local from './local';
import * as _npm from './npm';
Expand Down
5 changes: 5 additions & 0 deletions lib/config/types.ts
Expand Up @@ -350,3 +350,8 @@ export interface PackageRuleInputConfig extends Record<string, unknown> {
datasource?: string;
packageRules?: (PackageRule & PackageRuleInputConfig)[];
}

export interface ManagerConfig extends RenovateConfig {
language: string;
manager: string;
}
2 changes: 1 addition & 1 deletion lib/config/validation.spec.ts
@@ -1,6 +1,6 @@
import { getName } from '../../test/util';
import type { RenovateConfig } from './types';
import * as configValidation from './validation';
import { RenovateConfig } from '.';

describe(getName(__filename), () => {
describe('getParentName()', () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/bazel/update.spec.ts
Expand Up @@ -3,7 +3,7 @@ import { Readable } from 'stream';
import { resolve } from 'upath';
import * as httpMock from '../../../test/http-mock';
import { getName } from '../../../test/util';
import { UpdateType } from '../../config';
import type { UpdateType } from '../../config/types';
import { updateDependency } from './update';

const content = readFileSync(
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/gomod/update.spec.ts
@@ -1,6 +1,6 @@
import { readFileSync } from 'fs';
import { getName } from '../../../test/util';
import { UpdateType } from '../../config';
import type { UpdateType } from '../../config/types';
import { updateDependency } from './update';

const gomod1 = readFileSync('lib/manager/gomod/__fixtures__/1/go.mod', 'utf8');
Expand Down
2 changes: 1 addition & 1 deletion lib/util/emoji.ts
@@ -1,5 +1,5 @@
import emoji from 'node-emoji';
import { RenovateConfig } from '../config';
import type { RenovateConfig } from '../config/types';

let unicodeEmoji = false;

Expand Down
2 changes: 1 addition & 1 deletion lib/util/package-rules.spec.ts
@@ -1,4 +1,4 @@
import type { PackageRuleInputConfig, UpdateType } from '../config';
import type { PackageRuleInputConfig, UpdateType } from '../config/types';
import {
LANGUAGE_DOCKER,
LANGUAGE_JAVASCRIPT,
Expand Down
7 changes: 2 additions & 5 deletions lib/util/package-rules.ts
@@ -1,10 +1,7 @@
import is from '@sindresorhus/is';
import minimatch from 'minimatch';
import {
PackageRule,
PackageRuleInputConfig,
mergeChildConfig,
} from '../config';
import { mergeChildConfig } from '../config';
import type { PackageRule, PackageRuleInputConfig } from '../config/types';
import { logger } from '../logger';
import * as allVersioning from '../versioning';
import { configRegexPredicate, isConfigRegex, regEx } from './regex';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/automerge.spec.ts
@@ -1,6 +1,6 @@
import { defaultConfig, getName, git, platform } from '../../../test/util';
import { RenovateConfig } from '../../config';
import { setAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import { BranchStatus } from '../../types';
import { tryBranchAutomerge } from './automerge';

Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/automerge.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../config';
import { getAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import { logger } from '../../logger';
import { platform } from '../../platform';
import { BranchStatus } from '../../types';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/index.ts
@@ -1,6 +1,6 @@
import { DateTime } from 'luxon';
import { RenovateConfig } from '../../config';
import { getAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import {
CONFIG_VALIDATION,
MANAGER_LOCKFILE_ERROR,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/reuse.spec.ts
@@ -1,5 +1,5 @@
import { getName, git, platform } from '../../../test/util';
import { RenovateConfig } from '../../config';
import type { RenovateConfig } from '../../config/types';
import { Pr } from '../../platform';
import { PrState } from '../../types';
import { shouldReuseExistingBranch } from './reuse';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/reuse.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../config';
import { getAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import { logger } from '../../logger';
import { platform } from '../../platform';
import { branchExists, isBranchModified, isBranchStale } from '../../util/git';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/schedule.spec.ts
@@ -1,6 +1,6 @@
import mockDate from 'mockdate';
import { getName } from '../../../test/util';
import { RenovateConfig } from '../../config';
import type { RenovateConfig } from '../../config/types';
import * as schedule from './schedule';

describe(getName(__filename), () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/schedule.ts
@@ -1,7 +1,7 @@
import later from '@breejs/later';
import is from '@sindresorhus/is';
import { DateTime } from 'luxon';
import { RenovateConfig } from '../../config';
import type { RenovateConfig } from '../../config/types';
import { logger } from '../../logger';

const scheduleMappings: Record<string, string> = {
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/branch/status-checks.ts
@@ -1,4 +1,4 @@
import { RenovateConfig } from '../../config';
import type { RenovateConfig } from '../../config/types';
import { logger } from '../../logger';
import { platform } from '../../platform';
import { BranchStatus } from '../../types';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/global/autodiscover.spec.ts
@@ -1,5 +1,5 @@
import { getName } from '../../../test/util';
import { RenovateConfig } from '../../config';
import type { RenovateConfig } from '../../config/types';
import { PLATFORM_TYPE_GITHUB } from '../../constants/platforms';
import * as platform from '../../platform';
import * as _ghApi from '../../platform/github';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/global/autodiscover.ts
@@ -1,6 +1,6 @@
import is from '@sindresorhus/is';
import minimatch from 'minimatch';
import { GlobalConfig } from '../../config';
import type { GlobalConfig } from '../../config/types';
import { logger } from '../../logger';
import { platform } from '../../platform';

Expand Down
9 changes: 5 additions & 4 deletions lib/workers/global/index.ts
Expand Up @@ -5,8 +5,12 @@ import { satisfies } from 'semver';
import upath from 'upath';
import * as pkg from '../../../package.json';
import * as configParser from '../../config';
import { GlobalConfig } from '../../config';
import { validateConfigSecrets } from '../../config/secrets';
import type {
GlobalConfig,
RenovateConfig,
RenovateRepository,
} from '../../config/types';
import { getProblems, logger, setMeta } from '../../logger';
import { setUtilConfig } from '../../util';
import * as hostRules from '../../util/host-rules';
Expand All @@ -15,9 +19,6 @@ import { autodiscoverRepositories } from './autodiscover';
import { globalFinalize, globalInitialize } from './initialize';
import { Limit, isLimitReached } from './limits';

type RenovateConfig = configParser.RenovateConfig;
type RenovateRepository = configParser.RenovateRepository;

export async function getRepositoryConfig(
globalConfig: RenovateConfig,
repository: RenovateRepository
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/pr/index.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../config';
import { getAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import {
PLATFORM_INTEGRATION_UNAUTHORIZED,
PLATFORM_RATE_LIMIT_EXCEEDED,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/configured.ts
@@ -1,4 +1,4 @@
import { RenovateConfig } from '../../config';
import type { RenovateConfig } from '../../config/types';
import {
REPOSITORY_DISABLED_BY_CONFIG,
REPOSITORY_FORKED,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/dependency-dashboard.ts
@@ -1,7 +1,7 @@
import is from '@sindresorhus/is';
import { nameFromLevel } from 'bunyan';
import { RenovateConfig } from '../../config';
import { getAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import { getProblems, logger } from '../../logger';
import { Pr, platform } from '../../platform';
import { PrState } from '../../types';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/error-config.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../config';
import { getAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import { logger } from '../../logger';
import { platform } from '../../platform';
import { PrState } from '../../types';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/error.ts
@@ -1,4 +1,4 @@
import { RenovateConfig } from '../../config';
import type { RenovateConfig } from '../../config/types';

import {
CONFIG_SECRETS_EXPOSED,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/extract/index.spec.ts
@@ -1,5 +1,5 @@
import { defaultConfig, getName, git, mocked } from '../../../../test/util';
import { RenovateConfig } from '../../../config';
import type { RenovateConfig } from '../../../config/types';
import * as _managerFiles from './manager-files';
import { extractAllDependencies } from '.';

Expand Down
7 changes: 2 additions & 5 deletions lib/workers/repository/extract/index.ts
@@ -1,9 +1,6 @@
import is from '@sindresorhus/is';
import {
RenovateConfig,
getManagerConfig,
mergeChildConfig,
} from '../../../config';
import { getManagerConfig, mergeChildConfig } from '../../../config';
import type { RenovateConfig } from '../../../config/types';
import { logger } from '../../../logger';
import { getManagerList } from '../../../manager';
import type { PackageFile } from '../../../manager/types';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/extract/manager-files.spec.ts
@@ -1,5 +1,5 @@
import { fs, getConfig, getName, mocked } from '../../../../test/util';
import { RenovateConfig } from '../../../config';
import type { RenovateConfig } from '../../../config/types';
import * as _html from '../../../manager/html';
import * as _fileMatch from './file-match';
import { getManagerPackageFiles } from './manager-files';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/finalise/index.ts
@@ -1,4 +1,4 @@
import { RenovateConfig } from '../../../config';
import type { RenovateConfig } from '../../../config/types';
import { platform } from '../../../platform';
import * as repositoryCache from '../../../util/cache/repository';
import { pruneStaleBranches } from './prune';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/finalise/prune.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../../config';
import { getAdminConfig } from '../../../config/admin';
import type { RenovateConfig } from '../../../config/types';
import { REPOSITORY_CHANGED } from '../../../constants/error-messages';
import { logger } from '../../../logger';
import { platform } from '../../../platform';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/index.ts
@@ -1,6 +1,6 @@
import fs from 'fs-extra';
import { RenovateConfig } from '../../config';
import { setAdminConfig } from '../../config/admin';
import type { RenovateConfig } from '../../config/types';
import { logger, setMeta } from '../../logger';
import { deleteLocalFile, privateCacheDir } from '../../util/fs';
import * as queue from '../../util/http/queue';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/init/apis.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../../config';
import { configFileNames } from '../../../config/app-strings';
import type { RenovateConfig } from '../../../config/types';
import {
REPOSITORY_DISABLED_BY_CONFIG,
REPOSITORY_FORKED,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/init/cache.ts
@@ -1,5 +1,5 @@
import * as fs from 'fs-extra';
import { RenovateConfig } from '../../../config';
import type { RenovateConfig } from '../../../config/types';
import * as memCache from '../../../util/cache/memory';
import * as repositoryCache from '../../../util/cache/repository';
import { privateCacheDir } from '../../../util/fs';
Expand Down
3 changes: 2 additions & 1 deletion lib/workers/repository/init/config.ts
Expand Up @@ -3,12 +3,13 @@ import jsonValidator from 'json-dup-key-validator';
import JSON5 from 'json5';
import upath from 'upath';

import { RenovateConfig, mergeChildConfig } from '../../../config';
import { mergeChildConfig } from '../../../config';
import { configFileNames } from '../../../config/app-strings';
import { decryptConfig } from '../../../config/decrypt';
import { migrateAndValidate } from '../../../config/migrate-validate';
import { migrateConfig } from '../../../config/migration';
import * as presets from '../../../config/presets';
import type { RenovateConfig } from '../../../config/types';
import {
CONFIG_VALIDATION,
REPOSITORY_CHANGED,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/init/index.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../../config';
import { applySecretsToConfig } from '../../../config/secrets';
import type { RenovateConfig } from '../../../config/types';
import { logger } from '../../../logger';
import { clone } from '../../../util/clone';
import { setUserRepoConfig } from '../../../util/git';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/init/vulnerability.ts
@@ -1,4 +1,4 @@
import { PackageRule, RenovateConfig } from '../../../config';
import type { PackageRule, RenovateConfig } from '../../../config/types';
import { NO_VULNERABILITY_ALERTS } from '../../../constants/error-messages';
import * as datasourceMaven from '../../../datasource/maven';
import { id as npmId } from '../../../datasource/npm';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/onboarding/branch/check.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../../../config';
import { configFileNames } from '../../../../config/app-strings';
import type { RenovateConfig } from '../../../../config/types';
import {
REPOSITORY_CLOSED_ONBOARDING,
REPOSITORY_NO_CONFIG,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/onboarding/branch/config.ts
@@ -1,6 +1,6 @@
import { RenovateConfig } from '../../../../config';
import { getPreset } from '../../../../config/presets/local';
import { PRESET_DEP_NOT_FOUND } from '../../../../config/presets/util';
import type { RenovateConfig } from '../../../../config/types';
import { logger } from '../../../../logger';
import { clone } from '../../../../util/clone';

Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/onboarding/branch/create.ts
@@ -1,6 +1,6 @@
import { RenovateConfig } from '../../../../config';
import { getAdminConfig } from '../../../../config/admin';
import { configFileNames } from '../../../../config/app-strings';
import type { RenovateConfig } from '../../../../config/types';
import { logger } from '../../../../logger';
import { commitFiles } from '../../../../util/git';
import { formatCommitMessagePrefix } from '../../util/commit-message';
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/onboarding/branch/index.ts
@@ -1,5 +1,5 @@
import { RenovateConfig } from '../../../../config';
import { getAdminConfig } from '../../../../config/admin';
import type { RenovateConfig } from '../../../../config/types';
import {
REPOSITORY_FORKED,
REPOSITORY_NO_PACKAGE_FILES,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/onboarding/branch/rebase.ts
@@ -1,6 +1,6 @@
import { RenovateConfig } from '../../../../config';
import { getAdminConfig } from '../../../../config/admin';
import { configFileNames } from '../../../../config/app-strings';
import type { RenovateConfig } from '../../../../config/types';
import { logger } from '../../../../logger';
import {
commitFiles,
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/onboarding/pr/base-branch.ts
@@ -1,4 +1,4 @@
import { RenovateConfig } from '../../../../config';
import type { RenovateConfig } from '../../../../config/types';

export function getBaseBranchDesc(config: RenovateConfig): string {
// Describe base branch only if it's configured
Expand Down
2 changes: 1 addition & 1 deletion lib/workers/repository/onboarding/pr/pr-list.ts
@@ -1,4 +1,4 @@
import { RenovateConfig } from '../../../../config';
import type { RenovateConfig } from '../../../../config/types';
import { logger } from '../../../../logger';
import { emojify } from '../../../../util/emoji';
import type { BranchConfig } from '../../../types';
Expand Down

0 comments on commit b957d4a

Please sign in to comment.