fix(docker): use docker versioning for debian images with regular tags (

#17602)
renovatebot · Sep 4, 2022 · c4127f9 · c4127f9
1 parent 4ccd085
commit c4127f9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/modules/manager/dockerfile/extract.spec.ts b/lib/modules/manager/dockerfile/extract.spec.ts
@@ -649,6 +649,22 @@ describe('modules/manager/dockerfile/extract', () => {
       ]);
     });
 
+    it('handles debian with regular tag', () => {
+      const res = extractPackageFile('FROM debian:11.4-slim\n', '', {})?.deps;
+      expect(res).toEqual([
+        {
+          autoReplaceStringTemplate:
+            '{{depName}}{{#if newValue}}:{{newValue}}{{/if}}{{#if newDigest}}@{{newDigest}}{{/if}}',
+          currentDigest: undefined,
+          currentValue: '11.4-slim',
+          datasource: 'docker',
+          depName: 'debian',
+          depType: 'final',
+          replaceString: 'debian:11.4-slim',
+        },
+      ]);
+    });
+
     it('handles debian with prefixes', () => {
       const res = extractPackageFile('FROM amd64/debian:10\n', '', {})?.deps;
       expect(res).toEqual([

diff --git a/lib/modules/manager/dockerfile/extract.ts b/lib/modules/manager/dockerfile/extract.ts
@@ -208,7 +208,10 @@ export function getDep(
     dep.versioning = ubuntuVersioning.id;
   }
 
-  if (dep.depName === 'debian') {
+  if (
+    dep.depName === 'debian' &&
+    debianVersioning.api.isVersion(dep.currentValue)
+  ) {
     dep.versioning = debianVersioning.id;
   }