refactor(versioning): Enable strict null checks (#14053)

renovatebot · Feb 7, 2022 · c966eb1 · c966eb1
1 parent 968e29f
commit c966eb1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/lib/versioning/index.ts b/lib/versioning/index.ts
@@ -19,16 +19,11 @@ export function get(versioning: string): VersioningApi {
     logger.trace('Missing versioning, using semver as fallback.');
     return versionings.get('semver') as VersioningApi;
   }
-  let versioningName: string;
-  let versioningConfig: string;
+  const [versioningName, ...versioningRest] = versioning.split(':');
+  const versioningConfig = versioningRest.length
+    ? versioningRest.join(':')
+    : undefined;
 
-  if (versioning.includes(':')) {
-    const versionSplit = versioning.split(':');
-    versioningName = versionSplit.shift();
-    versioningConfig = versionSplit.join(':');
-  } else {
-    versioningName = versioning;
-  }
   const theVersioning = versionings.get(versioningName);
   if (!theVersioning) {
     logger.info({ versioning }, 'Unknown versioning - defaulting to semver');

diff --git a/tsconfig.strict.json b/tsconfig.strict.json
@@ -381,11 +381,6 @@
     "lib/util/ignore.ts",
     "lib/util/merge-confidence/index.ts",
     "lib/util/package-rules.ts",
-    "lib/versioning/api.ts",
-    "lib/versioning/common.ts",
-    "lib/versioning/helm/index.ts",
-    "lib/versioning/index.ts",
-    "lib/versioning/types.ts",
     "lib/workers/branch/artifacts.ts",
     "lib/workers/branch/auto-replace.ts",
     "lib/workers/branch/automerge.ts",