Skip to content

Commit

Permalink
ci(build): Remove Python from Renovate dependencies (#12685)
Browse files Browse the repository at this point in the history
Co-authored-by: Rhys Arkins <rhys@arkins.net>
  • Loading branch information
zharinov and rarkins committed Nov 17, 2021
1 parent 99a68e4 commit cf95251
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
10 changes: 0 additions & 10 deletions .github/workflows/build.yml
Expand Up @@ -37,26 +37,22 @@ jobs:
matrix:
os: [ubuntu-latest]
node-version: [14]
python-version: [3.9]
java-version: [11]
# skip macOS and Windows test on pull requests without 'ci:fulltest' label
include: >-
${{ fromJSON((github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'ci:fulltest')) && '[{
"os": "macos-latest",
"node-version": 14,
"python-version": 3.9,
"java-version": 11
}, {
"os": "windows-latest",
"node-version": 14,
"python-version": 3.9,
"java-version": 11
}]' || '[]') }}
env:
coverage: ${{ matrix.os == 'ubuntu-latest' && matrix.node-version == 14 }}
NODE_VERSION: ${{ matrix.node-version }}
PYTHON_VERSION: ${{ matrix.python-version }}
JAVA_VERSION: ${{ matrix.java-version }}
# skip Java tests on pull requests without 'ci:fulltest' label
SKIP_JAVA_TESTS: ${{ matrix.node-version != 14 || (github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'ci:fulltest')) }}
Expand All @@ -72,11 +68,6 @@ jobs:
node-version: ${{ env.NODE_VERSION }}
cache: yarn

- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@dc73133d4da04e56a135ae2246682783cc7c7cb6 # renovate: tag=v2.2.2
with:
python-version: ${{ env.PYTHON_VERSION }}

- name: Set up Java ${{ env.JAVA_VERSION }}
if: env.SKIP_JAVA_TESTS == 'false'
uses: actions/setup-java@8db439b6b47e5e12312bf036760bbaa6893481ac # renovate: tag=v2.3.1
Expand All @@ -96,7 +87,6 @@ jobs:
npm config set scripts-prepend-node-path true
git --version
echo "Node $(node --version)"
python --version
echo "Yarn $(yarn --version)"
- name: Installing dependencies
Expand Down
7 changes: 2 additions & 5 deletions docs/development/local-development.md
Expand Up @@ -14,7 +14,6 @@ You need the following dependencies for local development:
- Node.js `>=14.15.4`
- Yarn `^1.22.5`
- C++ compiler
- Python `^3.9`
- Java between `8` and `12`

We support Node.js versions according to the [Node.js release schedule](https://github.com/nodejs/Release#release-schedule).
Expand All @@ -31,7 +30,7 @@ curl -sL https://deb.nodesource.com/setup_14.x | sudo -E bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
sudo apt-get update
sudo apt-get install -y git python-minimal build-essential nodejs yarn default-jre-headless
sudo apt-get install -y git build-essential nodejs yarn default-jre-headless
```

You can also use [SDKMAN](https://sdkman.io/) to manage Java versions.
Expand All @@ -43,7 +42,7 @@ If you already installed a component, skip the corresponding step.

- Install [Git](https://git-scm.com/downloads). Make sure you've [configured your username and email](https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup)
- Install [Node.js LTS](https://nodejs.org/en/download/)
- In an Administrator PowerShell prompt, run `npm install -global npm` and then `npm --add-python-to-path='true' --debug install --global windows-build-tools`
- In an Administrator PowerShell prompt, run `npm install -global npm` and then `npm --debug install --global windows-build-tools`
- Install [Yarn](https://yarnpkg.com/lang/en/docs/install/#windows-stable)
- Install Java, e.g. from [AdoptOpenJDK](https://adoptopenjdk.net/?variant=openjdk11) or any other distribution

Expand All @@ -53,8 +52,6 @@ If you already installed a component, skip the corresponding step.
PS C:\Windows\system32> git --version
PS C:\Windows\system32> node --version
PS C:\Windows\system32> yarn --version
PS C:\Windows\system32> python --version
PS C:\Windows\system32> python -c "from unittest import mock; print(mock.__version__)"
PS C:\Windows\system32> java -version
```

Expand Down

0 comments on commit cf95251

Please sign in to comment.