fix(manager/npm): don't warn for empty .yarnrc.yml (#20149)

renovatebot · Feb 1, 2023 · d7d6d43 · d7d6d43
1 parent fabb1bb
commit d7d6d43
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 5 deletions.
diff --git a/lib/modules/manager/npm/extract/yarnrc.spec.ts b/lib/modules/manager/npm/extract/yarnrc.spec.ts
@@ -43,6 +43,16 @@ describe('modules/manager/npm/extract/yarnrc', () => {
       });
       expect(registryUrl).toBeNull();
     });
+
+    it('ignores missing scope registryServer', () => {
+      const registryUrl = resolveRegistryUrl('@scope/a-package', {
+        npmScopes: {
+          scope: {},
+        },
+        npmRegistryServer: 'https://private.example.com/npm',
+      });
+      expect(registryUrl).toBeNull();
+    });
   });
 
   describe('loadConfigFromYarnrcYml()', () => {
@@ -91,6 +101,7 @@ describe('modules/manager/npm/extract/yarnrc', () => {
         `,
         null,
       ],
+      ['', null],
     ])('produces expected config (%s)', (yarnrcYml, expectedConfig) => {
       const config = loadConfigFromYarnrcYml(yarnrcYml);
 

diff --git a/lib/modules/manager/npm/extract/yarnrc.ts b/lib/modules/manager/npm/extract/yarnrc.ts
@@ -17,11 +17,14 @@ export type YarnConfig = z.infer<typeof YarnrcYmlSchema>;
 
 export function loadConfigFromYarnrcYml(yarnrcYml: string): YarnConfig | null {
   try {
-    return YarnrcYmlSchema.parse(
-      load(yarnrcYml, {
-        json: true,
-      })
-    );
+    const obj = load(yarnrcYml, {
+      json: true,
+    });
+    if (!obj) {
+      // emtpy yaml file
+      return null;
+    }
+    return YarnrcYmlSchema.parse(obj);
   } catch (err) {
     logger.warn({ yarnrcYml, err }, `Failed to load yarnrc file`);
     return null;