fix(manager/helm): add hostType for helm dependencies during artifact…

…update (#17583) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
renovatebot · Sep 2, 2022 · e69a9ce · e69a9ce
1 parent d1dd05b
commit e69a9ce
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/lib/modules/manager/helmv3/artifacts.spec.ts b/lib/modules/manager/helmv3/artifacts.spec.ts
@@ -291,6 +291,7 @@ describe('modules/manager/helmv3/artifacts', () => {
     hostRules.add({
       username: 'basicUser',
       password: 'secret',
+      hostType: 'helm',
       matchHost: 'the_repo1_url',
     });
 

diff --git a/lib/modules/manager/helmv3/artifacts.ts b/lib/modules/manager/helmv3/artifacts.ts
@@ -14,6 +14,7 @@ import {
 } from '../../../util/fs';
 import * as hostRules from '../../../util/host-rules';
 import { DockerDatasource } from '../../datasource/docker';
+import { HelmDatasource } from '../../datasource/helm';
 import type { UpdateArtifact, UpdateArtifactsResult } from '../types';
 import type { ChartDefinition, Repository, RepositoryRule } from './types';
 import {
@@ -71,6 +72,7 @@ async function helmCommands(
         ...value,
         hostRule: hostRules.find({
           url: value.repository,
+          hostType: HelmDatasource.id,
         }),
       };
     });

diff --git a/lib/modules/manager/helmv3/readme.md b/lib/modules/manager/helmv3/readme.md
@@ -48,14 +48,16 @@ For this you use a custom `hostRules` array.
 {
   hostRules: [
     {
-      // global login
+      // global login for 'gitlab.com' if using Helm
       matchHost: 'gitlab.com',
+      hostType: 'helm', // this is optional, but else the credentials will be used for all request matching `matchHost`
       username: '<some-username>',
       password: '<some-password>',
     },
     {
       // specific repository
       matchHost: 'https://gitlab.com/api/v4/projects/xxxxxxx/packages/helm/stable',
+      hostType: 'helm', // this is optional
       username: '<some-username>',
       password: '<some-password>',
     },