refactor(workers/repository): Extract processUpdateArtifactResults me…

…thod (#27324)
renovatebot · Feb 17, 2024 · f9dc713 · f9dc713
1 parent 75d2d37
commit f9dc713
Showing 1 changed file with 34 additions and 29 deletions.
diff --git a/lib/workers/repository/update/branch/get-updated.ts b/lib/workers/repository/update/branch/get-updated.ts
@@ -6,6 +6,7 @@ import { get } from '../../../../modules/manager';
 import type {
   ArtifactError,
   PackageDependency,
+  UpdateArtifactsResult,
 } from '../../../../modules/manager/types';
 import { getFile } from '../../../../util/git';
 import type { FileAddition, FileChange } from '../../../../util/git/types';
@@ -299,16 +300,11 @@ export async function getUpdatedPackageFiles(
             newPackageFileContent: packageFile.contents!.toString(),
             config,
           });
-          if (is.nonEmptyArray(results)) {
-            for (const res of results) {
-              const { file, artifactError } = res;
-              if (file) {
-                updatedArtifacts.push(file);
-              } else if (artifactError) {
-                artifactErrors.push(artifactError);
-              }
-            }
-          }
+          processUpdateArtifactResults(
+            results,
+            updatedArtifacts,
+            artifactErrors,
+          );
         }
       }
     }
@@ -334,17 +330,13 @@ export async function getUpdatedPackageFiles(
             newPackageFileContent: packageFile.contents!.toString(),
             config,
           });
+          processUpdateArtifactResults(
+            results,
+            updatedArtifacts,
+            artifactErrors,
+          );
           if (is.nonEmptyArray(results)) {
             updatedPackageFiles.push(packageFile);
-            for (const res of results) {
-              const { file, artifactError } = res;
-              // istanbul ignore else
-              if (file) {
-                updatedArtifacts.push(file);
-              } else if (artifactError) {
-                artifactErrors.push(artifactError);
-              }
-            }
           }
         }
       }
@@ -367,16 +359,11 @@ export async function getUpdatedPackageFiles(
               newPackageFileContent: packageFileContents!,
               config,
             });
-            if (is.nonEmptyArray(results)) {
-              for (const res of results) {
-                const { file, artifactError } = res;
-                if (file) {
-                  updatedArtifacts.push(file);
-                } else if (artifactError) {
-                  artifactErrors.push(artifactError);
-                }
-              }
-            }
+            processUpdateArtifactResults(
+              results,
+              updatedArtifacts,
+              artifactErrors,
+            );
           }
         }
       }
@@ -389,3 +376,21 @@ export async function getUpdatedPackageFiles(
     artifactErrors,
   };
 }
+
+function processUpdateArtifactResults(
+  results: UpdateArtifactsResult[] | null,
+  updatedArtifacts: FileChange[],
+  artifactErrors: ArtifactError[],
+): void {
+  if (is.nonEmptyArray(results)) {
+    for (const res of results) {
+      const { file, artifactError } = res;
+      // istanbul ignore else
+      if (file) {
+        updatedArtifacts.push(file);
+      } else if (artifactError) {
+        artifactErrors.push(artifactError);
+      }
+    }
+  }
+}