Skip to content

Commit

Permalink
feat: support node v14 (#7582)
Browse files Browse the repository at this point in the history
  • Loading branch information
viceice committed Oct 29, 2020
1 parent 8d6993f commit fdf042b
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node-version: [12]
node-version: [12, ^14.15.0]
python-version: [3.8]
java-version: [8]
exclude:
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:

- name: Skip Java tests
if: env.NODE_VERSION != '12'
run: echo "::set-env name=SKIP_JAVA_TESTS::true"
run: echo "SKIP_JAVA_TESTS=true" >> $GITHUB_ENV

- name: Init platform
shell: bash
Expand Down
8 changes: 4 additions & 4 deletions docs/development/local-development.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Please submit PRs to improve it if you think anything is unclear or you can thin
For local development some dependencies are required:

- Git
- Node.js `>=12`
- Node.js `^12.13.0 || >=14.15.0`
- Yarn `^1.17.0`
- C++ compiler
- Python `^3.7`
Expand All @@ -26,7 +26,7 @@ _Linux_
You can use the following commands for `Ubuntu`.

```sh
curl -sL https://deb.nodesource.com/setup_12.x | sudo -E bash -
curl -sL https://deb.nodesource.com/setup_14.x | sudo -E bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | sudo apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sources.list.d/yarn.list
sudo apt-get update
Expand All @@ -49,9 +49,9 @@ The following steps work to set up a brand new Windows 10 installation for devel

```
PS C:\Windows\system32> git --version
git version 2.26.2.windows.1
git version 2.29.0.windows.1
PS C:\Windows\system32> node --version
v12.16.3
v14.15.0
PS C:\Windows\system32> yarn --version
1.22.4
PS C:\Windows\system32> python --version
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
},
"homepage": "https://renovatebot.com",
"engines": {
"node": ">=12",
"node": "^12.13.0 || >=14.15.0",
"yarn": "^1.17.0"
},
"dependencies": {
Expand Down

0 comments on commit fdf042b

Please sign in to comment.