fix: log warning for managers which don't support replacements (#13276)

Co-authored-by: Anne Stellingwerf <astellin@opentext.com>
renovatebot · Jan 14, 2022 · fe72cd7 · fe72cd7
1 parent 8112381
commit fe72cd7
Show file tree

Hide file tree

Showing 8 changed files with 49 additions and 2 deletions.
diff --git a/lib/manager/gomod/update.spec.ts b/lib/manager/gomod/update.spec.ts
@@ -279,5 +279,12 @@ describe('manager/gomod/update', () => {
       expect(res).not.toEqual(gomod1);
       expect(res).toContain('github.com/caarlos0/env/v6 v6.1.0');
     });
+    it('should return null for replacement', () => {
+      const res = updateDependency({
+        fileContent: undefined,
+        upgrade: { updateType: 'replacement' },
+      });
+      expect(res).toBeNull();
+    });
   });
 });
diff --git a/lib/manager/gomod/update.ts b/lib/manager/gomod/update.ts
@@ -16,7 +16,11 @@ export function updateDependency({
 }: UpdateDependencyConfig): string | null {
   try {
     logger.debug(`gomod.updateDependency: ${upgrade.newValue}`);
-    const { depName, depType } = upgrade;
+    const { depName, depType, updateType } = upgrade;
+    if (updateType === 'replacement') {
+      logger.warn('gomod manager does not support replacement updates yet');
+      return null;
+    }
     const depNameNoVersion = getDepNameWithNoVersion(depName);
     const lines = fileContent.split('\n');
     const lineToChange = lines[upgrade.managerData.lineNumber];

diff --git a/lib/manager/gradle/deep/index.spec.ts b/lib/manager/gradle/deep/index.spec.ts
@@ -494,5 +494,13 @@ describe('manager/gradle/deep/index', () => {
 
       expect(execSnapshots).toBeEmpty();
     });
+
+    it('should return null for replacement', () => {
+      const res = updateDependency({
+        fileContent: undefined,
+        upgrade: { deepExtract: true, updateType: 'replacement' },
+      });
+      expect(res).toBeNull();
+    });
   });
 });
diff --git a/lib/manager/gradle/deep/index.ts b/lib/manager/gradle/deep/index.ts
@@ -173,6 +173,11 @@ export function updateDependency({
   // prettier-ignore
   logger.debug(`gradle.updateDependency(): packageFile:${upgrade.packageFile} depName:${upgrade.depName}, version:${upgrade.currentValue} ==> ${upgrade.newValue}`);
 
+  if (upgrade.updateType === 'replacement') {
+    logger.warn('gradle manager does not support replacement updates yet');
+    return null;
+  }
+
   return updateGradleVersion(
     fileContent,
     buildGradleDependency(upgrade),

diff --git a/lib/manager/gradle/shallow/update.spec.ts b/lib/manager/gradle/shallow/update.spec.ts
@@ -75,4 +75,12 @@ describe('manager/gradle/shallow/update', () => {
       })
     ).toBeNull();
   });
+
+  it('should return null for replacement', () => {
+    const res = updateDependency({
+      fileContent: undefined,
+      upgrade: { updateType: 'replacement' },
+    });
+    expect(res).toBeNull();
+  });
 });
diff --git a/lib/manager/gradle/shallow/update.ts b/lib/manager/gradle/shallow/update.ts
@@ -7,7 +7,11 @@ export function updateDependency({
   fileContent,
   upgrade,
 }: UpdateDependencyConfig<GradleManagerData>): string | null {
-  const { depName, currentValue, newValue, managerData } = upgrade;
+  const { depName, currentValue, newValue, managerData, updateType } = upgrade;
+  if (updateType === 'replacement') {
+    logger.warn('gradle manager does not support replacement updates yet');
+    return null;
+  }
   const offset = managerData.fileReplacePosition;
   const leftPart = fileContent.slice(0, offset);
   const rightPart = fileContent.slice(offset);

diff --git a/lib/manager/maven/index.spec.ts b/lib/manager/maven/index.spec.ts
@@ -269,5 +269,12 @@ describe('manager/maven/index', () => {
         pomContent
       );
     });
+    it('should return null for replacement', () => {
+      const res = updateDependency({
+        fileContent: undefined,
+        upgrade: { updateType: 'replacement' },
+      });
+      expect(res).toBeNull();
+    });
   });
 });
diff --git a/lib/manager/maven/update.ts b/lib/manager/maven/update.ts
@@ -28,6 +28,10 @@ export function updateDependency({
   fileContent,
   upgrade,
 }: UpdateDependencyConfig): string | null {
+  if (upgrade.updateType === 'replacement') {
+    logger.warn('maven manager does not support replacement updates yet');
+    return null;
+  }
   const offset = fileContent.indexOf('<');
   const spaces = fileContent.slice(0, offset);
   const restContent = fileContent.slice(offset);